Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1695018

Summary:	[downstream clone - 4.3.4] Concurrent LSMs of the same disk can be issued via the REST-API
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	RHV bug bot <rhv-bugzilla-bot>
Component:	ovirt-engine	Assignee:	Ahmad Khiet <akhiet>
Status:	CLOSED ERRATA	QA Contact:	Yosi Ben Shimon <ybenshim>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.2.6	CC:	aefrat, fkust, gveitmic, Rhev-m-bugs, tnisan
Target Milestone:	ovirt-4.3.4	Keywords:	ZStream
Target Release:	4.3.1	Flags:	lsvaty: testing_plan_complete-
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	ovirt-engine-4.3.4	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	1660644	Environment:
Last Closed:	2019-06-20 14:48:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1660644
Bug Blocks:

Description RHV bug bot 2019-04-02 10:09:52 UTC

+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1660644 +++
======================================================================

Description of problem:

If an LSM of disk is issued via the REST-API, another LSM of the same disk is allowed and will result in;

  - a "Drive image file could not be found" error
  - the volumes existing in both storage domains
  - no live merge being performed


Doing the same with the VM down, the second 'nove' is not allowed, as it checks that the disk is locked.


Version-Release number of selected component (if applicable):

RHV 4.2.6


How reproducible:

Every time.


Steps to Reproduce:
1. Issue LSM of a disk via REST-API.
2. Issue it again.


Actual results:

Concurrent LSMs are allowed.


Expected results:

The second LSM should fail immediately, i.e. should be blocked until the first has completed.


Additional info:

(Originally by Gordon Watson)

Comment 5 RHV bug bot 2019-04-02 10:10:00 UTC

This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

(Originally by Sandro Bonazzola)

Comment 8 Yosi Ben Shimon 2019-05-30 13:33:39 UTC

Tested on:
ovirt-engine-4.3.4.1-0.1.el7.noarch
vdsm-4.30.16-3.el7ev.x86_64

The 2nd LSM (during the 1st one) fails as expected.

A new bug has been opened [1] as there was a side effect that causes the disk to be unable to move after the failure.
This happens when I try the 2nd LSM when the "RemoveSnapshotCommand" appears in the engine log.
If I try the 2nd LSM at this point, I get an "Internal Engine Error" and the disk gets stuck (The status is OK but can be moved).
All further tries fails with "Cannot move Virtual Disk. Disk ${DiskName} is being moved or copied".

[1]
https://bugzilla.redhat.com/show_bug.cgi?id=1715478

Moving to VERIFIED as the main issue in this bug works fine.

Comment 10 errata-xmlrpc 2019-06-20 14:48:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1566

Comment 11 Daniel Gur 2019-08-28 13:15:23 UTC

sync2jira

Comment 12 Daniel Gur 2019-08-28 13:21:10 UTC

sync2jira