Spec Name or Url: http://people.redhat.com/lmacken/obby.spec SRPM Name or Url: http://people.redhat.com/lmacken/obby-0.2.0-1.src.rpm Description: libobby is a library which provides synced document buffers. It supports multiple documents in one session and is portable to both Windows and Unix-like platforms.
Added gmp-devel to BuildRequires.
After a quick glance at the spec file I can see the same issues as with net6: -devel requires at least pkgconfig use the %find_lang macro
Done. http://people.redhat.com/lmacken/obby.spec http://people.redhat.com/lmacken/obby-0.2.0-2.src.rpm
-devel subpackage needs to require: net6-devel as the include files from obby-devel include net6 headers files. The BuildRequires libsigc++20-devel is not necessary as this is already required by net6-devel. The rest looks good.
Updated. http://people.redhat.com/lmacken/gobby.spec http://people.redhat.com/lmacken/gobby-0.2.2-1.src.rpm
Fixed srpm: http://people.redhat.com/lmacken/gobby-0.2.2-3.src.rpm
Forgot one more thing: the -devel subpackage also requires gmp-devel as it can be seen it buffer.hpp and rsa.hpp By the way: SRPM gives a 404 and the spec file is the SRPM.
updated.. links should be good now. http://people.redhat.com/lmacken/gobby.spec http://people.redhat.com/lmacken/gobby-0.2.2-3.src.rpm
Per Adrian's comment #2, I'd suggest adding to %install: %find_lang %{name} and to %files: %files -f %{name}.lang instead of hard-coding %{_datadir}/locale/*/LC_MESSAGES/gobby.mo
Updating bugzilla summary to match package name/summary.
OK, it appears there are 2 packages for Review here (so I got confused): * obby: library * gobby: editor, which BuildRequires: obby-devel For reviewers' sanity, I'd suggest submitting each in its own bugzilla entry.
(In reply to comment #11) > OK, it appears there are 2 packages for Review here (so I got confused): > * obby: library > * gobby: editor, which BuildRequires: obby-devel > > For reviewers' sanity, I'd suggest submitting each in its own bugzilla entry. Obby: This bug Gobby: Bug #169514 I'm to blame for this confusion seeing as I pasted links to gobby spec/srpm starting in comment #5; all of the review in this bug is for the obby library.
Latest spec/srpm: http://people.redhat.com/lmacken/obby-0.2.0-3.src.rpm http://people.redhat.com/lmacken/obby.spec Sorry for the confusion guys.
* builds in mock * rpmlint is happy * correct usage of -devel * spec looks good * clean installation and removal * use of find_lang macro * correct Requires and BuildRequires * scriptlets look sane APPROVED
* Imported into cvs * Added to owners.list * Requested FC3/FC4 branches * Build sucessfully in devel branch Thanks!
You could add --with-howl to configure and the BR howl-devel to the spec for FC-4 and greater.
Built howl support into the devel branch. Will add it to FC4 shortly after.