Bug 1695391 - GF_LOG_OCCASSIONALLY API doesn't log at first instance
Summary: GF_LOG_OCCASSIONALLY API doesn't log at first instance
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: logging
Version: 5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On: 1694925
Blocks: 1695390
TreeView+ depends on / blocked
 
Reported: 2019-04-03 02:38 UTC by Atin Mukherjee
Modified: 2019-04-18 11:10 UTC (History)
1 user (show)

Fixed In Version: glusterfs-5.6
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1694925
Environment:
Last Closed: 2019-04-08 14:16:07 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 22483 0 None Merged logging: Fix GF_LOG_OCCASSIONALLY API 2019-04-08 14:16:06 UTC

Description Atin Mukherjee 2019-04-03 02:38:53 UTC
+++ This bug was initially created as a clone of Bug #1694925 +++

Description of problem:

    GF_LOG_OCCASSIONALLY doesn't log on the first instance rather at every
    42nd iterations which isn't effective as in some cases we might not have
    the code flow hitting the same log for as many as 42 times and we'd end
    up suppressing the log.


Version-Release number of selected component (if applicable):

Mainline

How reproducible:

Always

--- Additional comment from Worker Ant on 2019-04-02 05:35:15 UTC ---

REVIEW: https://review.gluster.org/22475 (logging: Fix GF_LOG_OCCASSIONALLY API) posted (#1) for review on master by Atin Mukherjee

--- Additional comment from Worker Ant on 2019-04-02 10:57:31 UTC ---

REVIEW: https://review.gluster.org/22475 (logging: Fix GF_LOG_OCCASSIONALLY API) merged (#2) on master by Atin Mukherjee

Comment 1 Worker Ant 2019-04-03 02:42:29 UTC
REVIEW: https://review.gluster.org/22483 (logging: Fix GF_LOG_OCCASSIONALLY API) posted (#1) for review on release-5 by Atin Mukherjee

Comment 2 Worker Ant 2019-04-08 14:16:07 UTC
REVIEW: https://review.gluster.org/22483 (logging: Fix GF_LOG_OCCASSIONALLY API) merged (#2) on release-5 by Shyamsundar Ranganathan

Comment 3 Shyamsundar 2019-04-18 11:10:09 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.6, please open a new bug report.

glusterfs-5.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2019-April/000123.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.