Bug 1696397 - `oc describe` displays labels with invalid spacing and capitalization
Summary: `oc describe` displays labels with invalid spacing and capitalization
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Machine Config Operator
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.1.0
Assignee: Kirsten Garrison
QA Contact: Micah Abbott
Depends On:
TreeView+ depends on / blocked
Reported: 2019-04-04 18:47 UTC by Justin Pierce
Modified: 2019-04-10 12:52 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2019-04-10 12:52:46 UTC
Target Upstream Version:

Attachments (Terms of Use)

Description Justin Pierce 2019-04-04 18:47:56 UTC
Description of problem:
oc describe on several machineconfig apis displays labels names with corrupting spacing and capitalization. 

For example (from `oc describe machineconfigpool worker`):
  Machine Config Selector:
    Match Labels:
      Machineconfiguration . Openshift . Io / Role:  worker
  Machine Selector:
    Match Labels:
      Node - Role . Kubernetes . Io / Worker:  

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. oc describe machineconfigpool worker

Actual results:
Label names corrupted with spacing and capitalization..
 Machineconfiguration . Openshift . Io / Role:  worker

Expected results:
 machineconfiguration.openshift.io/role: worker

Additional details:
Other resources are also affected (e.g. machinesets)

Comment 1 Kirsten Garrison 2019-04-04 22:00:55 UTC
Spun up a cluster and can confirm that the output is the same as described.

Comment 2 Kirsten Garrison 2019-04-04 22:48:01 UTC
Figured out the problem:

So this is related to kubectl's describe : https://github.com/kubernetes/kubernetes/blob/fd98e7abf042251bb094a5535d67f53d36021246/pkg/kubectl/describe/versioned/describe.go#L306

The smartLabelFor() function is what is adding the capitalization and the spaces.

However ~2 weeks ago, a PR was merged into the upstream that fixes this issue:

To fix this we'd have to update our oc which is using 1.13 currently.

I'm going to ask about this in #forum-devex and will update to the resolution.

Comment 3 Kirsten Garrison 2019-04-04 23:00:41 UTC
According to the original issue filing upstream, the fix will be in v1.15:

Comment 4 Kirsten Garrison 2019-04-05 19:29:18 UTC
Update: as of right now 1.15 (containing this fix) would be pulled into 4.3, so we'd get it in the fall. Right now master team is dealing with blockers but might be able to get it in a bit sooner, but we'd have to follow up later.

Comment 5 Kirsten Garrison 2019-04-09 21:20:38 UTC
Opened #1698235 to track this in master since they are in charge of this part of `oc`

This BZ can be closed.

Comment 6 Kirsten Garrison 2019-04-09 21:22:22 UTC
See Bug 1698235 (hoping this creates a link)

Comment 7 Antonio Murdaca 2019-04-10 12:52:46 UTC
Closing as this is not MCO specific but a fix should land in oc itself.

Note You need to log in before you can comment on or make changes to this bug.