Bug 1696726 - [OCP4 Beta] [marketplace] NodeSelector missing for openshift-marketplace
Summary: [OCP4 Beta] [marketplace] NodeSelector missing for openshift-marketplace
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: OLM
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.2.0
Assignee: Aravindh Puthiyaparambil
QA Contact: Fan Jia
Depends On:
TreeView+ depends on / blocked
Reported: 2019-04-05 13:58 UTC by Derek Carr
Modified: 2019-11-13 09:18 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: marketplace operator always overwrites the pod deployment spec of registry deployments associated with OperatorSources Consequence: Users cannot NodeSelectors Fix: Only replace the required fields in the deployment spec on OperatorSource updates, allowing users to add NodeSelectors to the operator registry pod associated with OperatorSources. By default no NodeSelector will be present by design. Result: Users can NodeSelectors to the pod spec in the registry pod deployments. Example: For the "community-operators" OperatorSource, the user would edit the "community-operators" deployment in the "openshift-marketplace" namespace.
Clone Of:
Last Closed: 2019-10-16 06:28:05 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github operator-framework operator-marketplace pull 216 0 'None' closed Bug 1696726: Don't replace pod spec on updates 2020-07-29 00:49:17 UTC
Red Hat Product Errata RHBA-2019:2922 0 None None None 2019-10-16 06:28:22 UTC

Description Derek Carr 2019-04-05 13:58:21 UTC
Description of problem:

The operators that are responsible for the pods in the namespaces 
- openshift-marketplace

have no option to configure the workload via an NodeSelector.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Deploy cluster
2. There is no NodeSelector available to configure the workload as desired

see: https://bugzilla.redhat.com/show_bug.cgi?id=1696444

Comment 1 Jian Zhang 2019-04-08 05:47:12 UTC

The marketplace-operator runs on the master nodes, and its "replicas" is 1. As below:
mac:~ jianzhang$ oc get deployment marketplace-operator -o yaml|grep -i nodeSelector -A 2
        node-role.kubernetes.io/master: ""
      priorityClassName: system-cluster-critical

mac:~ jianzhang$ oc get deployment marketplace-operator -o yaml|grep replicas
  replicas: 1
  replicas: 1

mac:~ jianzhang$ oc get pods -o wide
NAME                                    READY     STATUS    RESTARTS   AGE       IP            NODE                                           NOMINATED NODE   READINESS GATES
certified-operators-7bd7768fcf-lbxb2    1/1       Running   0          3h49m    ip-172-31-130-114.us-east-2.compute.internal   <none>           <none>
community-operators-74d75b747c-d7rvr    1/1       Running   0          3h49m    ip-172-31-151-102.us-east-2.compute.internal   <none>           <none>
marketplace-operator-5d8bf7668f-r28pn   1/1       Running   0          3h49m   ip-172-31-158-104.us-east-2.compute.internal   <none>           <none>
redhat-operators-6865f9b7b5-g9xm4       1/1       Running   0          3h49m    ip-172-31-130-114.us-east-2.compute.internal   <none>           <none>

Comment 2 Florin Peter 2019-04-08 06:32:59 UTC
Hi Jian,

only the marketplace-operator is running on the masters, all others pods in the namespace openshift-marketplace are not bound via nodeSelector to the masters.

oc get po -n openshift-marketplace -o wide
NAME                                    READY   STATUS    RESTARTS   AGE     IP              NODE                                      NOMINATED NODE
certified-operators-7dc989fc9d-fmzl7    1/1     Running   0          3d18h   ocp4-nmz4m-infra-s2large4-eude03-nxbfd    <none>
community-operators-5995cd994b-szhrq    1/1     Running   0          3d18h   ocp4-nmz4m-infra-s2large4-eude03-nxbfd    <none>
marketplace-operator-6ffff946cc-24vm7   1/1     Running   0          3d18h    ocp4-nmz4m-master-2                       <none>
redhat-operators-6c5595fd66-mk224       1/1     Running   0          3d18h    ocp4-nmz4m-worker-s2large4-eude03-rwmgn   <none>

From my point of view it will be good to be able to bind the pods to the infra nodes.

Comment 3 Aravindh Puthiyaparambil 2019-04-08 21:36:44 UTC
certified-operators, redhat-operators and community-operator pods are ones associated with CatalogSources that are created as a result of adding those OperatorSources (which is a CR that the marketplace operator watches) to the cluster. They are not part of the marketplace operator. Given that, they shouldn't be bound to the master node via a nodeSelector.

Comment 4 Aravindh Puthiyaparambil 2019-04-10 16:53:01 UTC
After discussing with Jessica, we concluded that the grpc CatalogSource pods should *not* be running on master as they are secondary resources. Moreover they should be launched with multiple replicas in such a way that the OperatorHub experience does not degrade. Currently we shouldn't see any degradation given the way CatalogSource are synced, but we should not depend on that. This is something we can fix in the 4.2 time frame rather introducing this change at this juncture.

Comment 10 errata-xmlrpc 2019-10-16 06:28:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.