Bug 1696748 - UI exception seen when creating the new logical network and selecting that network
Summary: UI exception seen when creating the new logical network and selecting that ne...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.3.2.1
Hardware: x86_64
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.4.0
: ---
Assignee: Sharon Gratch
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks: 1696749
TreeView+ depends on / blocked
 
Reported: 2019-04-05 14:39 UTC by SATHEESARAN
Modified: 2020-05-28 09:31 UTC (History)
3 users (show)

Fixed In Version: rhv-4.4.0-29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1696749 (view as bug list)
Environment:
Last Closed: 2020-04-16 10:36:36 UTC
oVirt Team: Network
Embargoed:
sbonazzo: ovirt-4.3?
pm-rhel: ovirt-4.4+
sbonazzo: planning_ack?
pm-rhel: devel_ack+
sbonazzo: testing_ack?


Attachments (Terms of Use)
screenshot showing UI exceptions (43.92 KB, image/png)
2019-04-05 14:42 UTC, SATHEESARAN
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 99479 0 'None' MERGED webadmin: Fix NPE that may raise in SubTabHostVmView 2020-08-27 12:57:50 UTC
oVirt gerrit 106304 0 ovirt-engine-4.3 MERGED webadmin: Fix NPE that may raise in SubTabHostVmView 2020-08-27 12:57:49 UTC

Description SATHEESARAN 2019-04-05 14:39:59 UTC
Description of problem:
------------------------
When creating the new logical network from RHV Manager UI and selecting that network, UI exception is observed


Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHV 4.3.3-2

How reproducible:
-----------------
3/3

Steps to Reproduce:
-------------------
1. After successful HE deployment, create a new logical network from RHV Manager UI
2. Select the network to update the cluster role


Actual results:
----------------
UI Exception seen after selecting the network

Expected results:
-----------------
No UI exception

Comment 1 SATHEESARAN 2019-04-05 14:40:29 UTC
[root@ ovirt-engine]# cat ui.log 
2019-04-05 20:04:40,904+05 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-8) [] Permutation name: BC99BBBD890F6857A69025E7C8C1D9B2
2019-04-05 20:04:40,905+05 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-8) [] Uncaught exception: com.google.gwt.core.client.JavaScriptException: (TypeError) : oab(...) is null
	at org.ovirt.engine.ui.webadmin.section.main.view.tab.host.SubTabHostVmView$3.$getValue(SubTabHostVmView.java:119)
	at org.ovirt.engine.ui.webadmin.section.main.view.tab.host.SubTabHostVmView$3.getValue(SubTabHostVmView.java:119)
	at com.google.gwt.user.cellview.client.Column.render(Column.java:164) [gwt-servlet.jar:]
	at com.google.gwt.user.cellview.client.AbstractCellTableBuilder.$renderCell(AbstractCellTableBuilder.java:188) [gwt-servlet.jar:]
	at com.google.gwt.user.cellview.client.DefaultCellTableBuilder.$buildRowImpl(DefaultCellTableBuilder.java:62) [gwt-servlet.jar:]
	at com.google.gwt.user.cellview.client.AbstractCellTableBuilder.$buildRow(AbstractCellTableBuilder.java:85) [gwt-servlet.jar:]
	at com.google.gwt.user.cellview.client.AbstractCellTable.$buildRowValues(AbstractCellTable.java:2350) [gwt-servlet.jar:]
	at com.google.gwt.user.cellview.client.AbstractCellTable.replaceAllChildren(AbstractCellTable.java:2149) [gwt-servlet.jar:]
	at com.google.gwt.user.cellview.client.AbstractHasData$View.replaceAllChildren(AbstractHasData.java:265) [gwt-servlet.jar:]
	at com.google.gwt.user.cellview.client.HasDataPresenter.$resolvePendingState(HasDataPresenter.java:1062) [gwt-servlet.jar:]
	at com.google.gwt.user.cellview.client.HasDataPresenter$2.execute(HasDataPresenter.java:981) [gwt-servlet.jar:]
	at com.google.gwt.core.client.impl.SchedulerImpl.runScheduledTasks(SchedulerImpl.java:167) [gwt-servlet.jar:]
	at com.google.gwt.core.client.impl.SchedulerImpl.$flushFinallyCommands(SchedulerImpl.java:272) [gwt-servlet.jar:]
	at com.google.gwt.core.client.impl.Impl.exit(Impl.java:313) [gwt-servlet.jar:]
	at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:275) [gwt-servlet.jar:]
	at Unknown.Su/<(https://hostedenginesm4.lab.eng.blr.redhat.com/ovirt-engine/webadmin/?locale=en_US line 9 > scriptElement)
	at Unknown.anonymous(Unknown)

Comment 2 SATHEESARAN 2019-04-05 14:42:01 UTC
Created attachment 1552538 [details]
screenshot showing UI exceptions

UI exception after selecting the newly created logical network

Comment 3 Michael Burman 2019-04-07 14:39:57 UTC
Hi,

QE can't reproduce this report. Can you please be more specific with the steps. You mentioned update cluster role, which role?

Comment 4 Sharon Gratch 2019-04-16 10:46:48 UTC
@sasundar, I posted a patch that may fix the issue and is based on the exception stack trace only.
So please try to reproduce the exception to make sure that this fix really solves the problem.

Comment 5 SATHEESARAN 2019-04-26 16:31:04 UTC
(In reply to Michael Burman from comment #3)
> Hi,
> 
> QE can't reproduce this report. Can you please be more specific with the
> steps. You mentioned update cluster role, which role?

My intent was to set gluster role on that logical network, but when selecting the
network itself I got this exception.

Comment 6 SATHEESARAN 2019-04-26 16:33:29 UTC
(In reply to Sharon Gratch from comment #4)
> @sasundar, I posted a patch that may fix the issue and is based on the
> exception stack trace only.
> So please try to reproduce the exception to make sure that this fix really
> solves the problem.

Hi Sharon,

I am unable to hit this problem with the latest RHV 4.3.3 compose.
Could you root cause the issue based on the stack trace ?

Comment 7 Dominik Holler 2019-04-30 13:56:43 UTC
Sas, do you think the fix should be backported and can you do the verification of this bug?

Comment 8 SATHEESARAN 2019-05-01 02:46:37 UTC
(In reply to Dominik Holler from comment #7)
> Sas, do you think the fix should be backported and can you do the
> verification of this bug?

Based on the testing results, I couldn't hit issue any more with RHV 4.3.3 & RHGS 3.4.4

Possibly there could be 2 things happened:
1. Problem fixed
2. Problem suppressed and not showing up for now.

If problem is already fixed, we are double happy.
But I am worried about case2, where the problem is not showing up, but still there in the code.

If the fix for stacktrace looks genuine, and the fix really is required, I can take up the verification of this bug.

Comment 9 Sharon Gratch 2019-05-02 13:43:19 UTC
(In reply to SATHEESARAN from comment #8)
> Based on the testing results, I couldn't hit issue any more with RHV 4.3.3 &
> RHGS 3.4.4
> 
> Possibly there could be 2 things happened:
> 1. Problem fixed
> 2. Problem suppressed and not showing up for now.
> 
> If problem is already fixed, we are double happy.
> But I am worried about case2, where the problem is not showing up, but still
> there in the code.
> 
> If the fix for stacktrace looks genuine, and the fix really is required, I
> can take up the verification of this bug.

The reason I'm not sure if the posted patch really fix this issue and not something else is because the fix is based on the exception stack trace mentioned in comment #1 which shows the exception triggered by the SubTabHostVmView (which is the Hosts main tab->VMs sub tab), while the screenshot attached https://bugzilla.redhat.com/attachment.cgi?id=1552538 shows that the exception is triggered by the Networks main tab.

Do you by any chance have the ui.log from the time of the exception? Maybe there are other exceptions relevant to the Networks dialog?

If you don't have the old ui.log and we can't reproduce it on an older version prior to this fix and compare to current build with the fix then I suggest to verify the bug and hope it fixed the issue. 


(In reply to Dominik Holler from comment #7)
> Sas, do you think the fix should be backported

A good question. The code caused the exception was added on oVirt 4.3.2 but we are not 100% sure if it fixes the issue or not.

Comment 10 SATHEESARAN 2019-05-03 06:25:45 UTC
(In reply to Sharon Gratch from comment #9)
> If you don't have the old ui.log and we can't reproduce it on an older
> version prior to this fix and compare to current build with the fix then I
> suggest to verify the bug and hope it fixed the issue. 

I think this suggestion is good to go, as I can't reproduce the issue with the latest RHV 4.3.3
and I don't have all the logs in the setup.

Comment 11 Dominik Holler 2019-05-14 13:16:52 UTC
Since no one is pushing this into 4.3, I target the bug to 4.4.

Comment 12 Sandro Bonazzola 2020-02-27 09:10:07 UTC
This bug is referenced in ovirt-engine-4.3.9.1 git log (https://gerrit.ovirt.org/106304 ).
Please cross check this is not really being fixed in 4.3.9.

Comment 14 Lukas Svaty 2020-04-16 10:36:36 UTC
Closing low severity bugs, based on QE capacity, if you would like to still verify this issue please reopen.


Note You need to log in before you can comment on or make changes to this bug.