Red Hat Bugzilla – Bug 169717
Review Request: Internode DSL usage applet
Last modified: 2007-11-30 17:11:14 EST
Spec Name or Url: http://frontiernet.net/~jpmahowald/fedora/review/gnome-applet-internode.spec SRPM Name or Url: http://frontiernet.net/~jpmahowald/fedora/review/gnome-applet-internode-1.3-1.src.rpm Description: The Internode Usage Meter for GNOME is a panel applet for the GNOME 2 desktop environment which allows you to monitor your Internode Personal ADSL Usage. (Packaging for: http://fedoraforum.org/forum/showthread.php?t=79173)
Note that this has not been tested with a real Internode ADSL account yet. http://www.internode.on.net/
Just a couple of initial comments: * I believe the Requires: python-abi is no longer needed for FC4+5. * Use %{SOURCE1} in %prep instead of %{_sourcedir}. It's a little easier to read. * There is a debug 'echo' line in %install I've never been clear on the recommendations for .pyc files. Should these be shipped or %ghosted? I will try to do a more formal review later today...
Build error on FC-4 x86_64. It looks like the package installs some files into /usr/lib instead of %{_libdir} File not found: /var/tmp/gnome-applet-internode-1.3-1-root-rpmbuild/usr/lib64/bonobo/servers/InternodeUsageMeterApplet.server
Also, I may not be able to make this noarch, because bonobo is installed at %{_libdir}. Even though the only thing it puts there is a single text file. I will have to rework the setup patch.
More build erros, this time on devel-i386: error: Installed (but unpackaged) file(s) found: /usr/bin/internode-applet.pyc /usr/bin/internode-applet.pyo These should probably be %ghosted.
Actually, I think they should be just %exclude'd (can't rm -f because they're generated by rpmbuild after %install). As far as I can tell, there should be no reason for rpmbuild to byte-compile *.py scripts in /usr/bin.
GOOD ==== * rpmlint output clean * No redundance or not permissible BR: * Source matches upstream * Package name follows guidelines for gnome applets * Builds on FC4-i386 * spec file legible, in Am. English * macro use consistent * code, not content * No shared libraries or -devel package * doc ok * desktop file not needed * Runs without crashing (did not test with a valid Internode account, however) Recommended (but not required) ==== * Use %{SOURCE1} instead of {%_sourcedir}/COPYING * Add %{?dist} to release tag * GPL license ok, text included * Does not build on FC5-i386 or FC4-x86_64. * mock build not tested (my mock env. is hosed right now) MUSTFIX: * %exclude %{_bindir}/*.pyc %{_bindir}/*.pyo (comment #6) * Requires: python-abi not needed for FC-5 (comment #2) * Fix x86_64 build with respect to /usr/lib (comment #3) * Does not own all directories that it creates: - %{python_sitelib}/internode/ - %{datadir}/internode/ - %{_libdir}/bonobo/servers (probably owned by a parent of one of the Requires, but was unable to verify)
Ping?
Ping Can we either fix this or close the bug?
I really am not going to use this. Closing. If anybody would like to take over based on this spec feel free.