Bug 1697267 - authselect cannot validate its own files
Summary: authselect cannot validate its own files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: authselect
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pavel Březina
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1734302
TreeView+ depends on / blocked
 
Reported: 2019-04-08 08:43 UTC by Lukas Slebodnik
Modified: 2019-08-02 10:30 UTC (History)
3 users (show)

Fixed In Version: authselect-1.0.4-1.fc29
Clone Of:
: 1734302 (view as bug list)
Environment:
Last Closed: 2019-07-30 01:45:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lukas Slebodnik 2019-04-08 08:43:22 UTC
Description of problem:
Sometimes I can see failures when enabling/disabling features.
Even though there were not any manual changes to files.

e.g.
sh$ authselect enable-feature with-mkhomedir'
[error] [/etc/authselect/postlogin] has unexpected content!
[error] Unexpected changes to the configuration were detected.
[error] Refusing to activate profile unless those changes are removed or overwrite is requested.
Unable to enable feature [17]: File exists

sh$ authselect enable-feature with-mkhomedir'
[error] [/etc/authselect/dconf-locks] has unexpected content!
[error] Unexpected changes to the configuration were detected.
[error] Refusing to activate profile unless those changes are removed or overwrite is requested.
Unable to enable feature [17]: File exists

Version-Release number of selected component (if applicable):
authselect-1.0.3-1.fc30.x86_64

How reproducible:
I do not have deterministic reproducer.
Just run tests many times.

Additional info:
sh-5.0# authselect check
[error] [/etc/authselect/postlogin] has unexpected content!
Current configuration is not valid. It was probably modified outside authselect.

sh-5.0# diff -i /etc/authselect/postlogin /var/lib/authselect/postlogin
1c1
< # Generated by authselect on Sat Apr  6 17:02:02 2019
---
> # Generated by authselect on Sat Apr  6 17:02:01 2019



sh-5.0# authselect check
[error] [/etc/authselect/postlogin] has unexpected content!
Current configuration is not valid. It was probably modified outside authselect.
sh-5.0# 
sh-5.0# diff /etc/authselect/postlogin /var/lib/authselect/postlogin
1c1
< # Generated by authselect on Sat Apr  6 17:02:02 2019
---
> # Generated by authselect on Sat Apr  6 17:02:01 2019

Comment 1 Pavel Březina 2019-04-10 09:30:48 UTC
Thank you. I will try to reproduce it.

Comment 2 Pavel Březina 2019-04-11 10:13:53 UTC
Upstream ticket:
https://github.com/pbrezina/authselect/issues/146

Comment 3 Pavel Březina 2019-04-25 08:42:28 UTC
Steps to reproduce:

$ sudo gdb -quiet authselect -ex 'set breakpoint pending on' -ex 'b src/lib/files/system.c:428' -ex 'run select sssd --force' -ex 'shell sleep 1' -ex 'detach' -ex 'quit'
$ sudo authselect check
[error] [/dev/shm/authselect-install/etc/authselect/system-auth] has unexpected content!
Current configuration is not valid. It was probably modified outside authselect.

Comment 4 Ben Cotton 2019-05-02 19:39:15 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2019-05-28 23:57:06 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 6 Fedora Update System 2019-06-13 09:55:44 UTC
FEDORA-2019-84659dbcb4 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-84659dbcb4

Comment 7 Fedora Update System 2019-06-14 02:12:31 UTC
authselect-1.0.4-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-84659dbcb4

Comment 8 John 2019-07-24 06:26:12 UTC
YOU SEE WHAT HAPPENS WHEN YOU REFUSE TO FIX A PROBLEM PROPERLY IN FEDORA?

IT ENDS UP IN YOUR "Enterprise" OS, EL8:

    [error] [/etc/authselect/password-auth] has unexpected content!
    [error] Unexpected changes to the configuration were detected.
    [error] Refusing to activate profile unless those changes are removed or overwrite is requested.

I very much doubt /etc/authselect/password-auth has been modified by *ANYTHING* besides authselect, as it doesn't look like something systemd would bother with.

Just ridiculous.

authselect-1.0-13.el8

Comment 9 John 2019-07-24 06:33:58 UTC
# cat /etc/authselect/password-auth
# Generated by authselect on Wed Jul 24 16:14:19 2019
...

And look at this:

#stat  /etc/authselect/password-auth
  File: /etc/authselect/password-auth
  Size: 2062            Blocks: 8          IO Block: 4096   regular file
Device: fd00h/64768d    Inode: 6293724     Links: 1
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Context: system_u:object_r:etc_t:s0
Access: 2019-07-24 16:16:04.383700066 +1000
Modify: 2019-07-24 16:14:19.001835541 +1000
Change: 2019-07-24 16:14:19.069836099 +1000

File has not been modified since authselect generated it.



authselect cannot validate its own files

FIX IT.

Comment 10 Fedora Update System 2019-07-30 01:45:14 UTC
authselect-1.0.4-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Pavel Březina 2019-07-30 08:27:05 UTC
John, I am sorry for your troubles. This has been already fixed in RHEL 8.1 as part of authselect-1.1 rebase [1]. I just created a tracker bug [2] to make it clear.

If you are RHEL customer you can opt in to public beta to test it [3]. If you want this fixed also in RHEL 8.0.z, please move this communication to customer portal. Thank you.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1685516
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1734302
[3] https://www.redhat.com/en/blog/red-hat-enterprise-linux-81-beta-now-available

Comment 12 John 2019-08-02 10:30:41 UTC
Ah thank you Pavel.

Sorry I am so rude when i report bugs, i am a very impatient and unpleasant grumpy old bastard I know :-(


Note You need to log in before you can comment on or make changes to this bug.