This package already exists for EPEL, but I'd like to un-retire in for Fedora branches. The package is only useful for Lua < 5.3, so only compat-lua version will be built for Fedora. The package in EPEL will stay as is, but I've re-written the spec to support both Fedora and EPEL. Spec URL: https://tkrizek.fedorapeople.org/lua-bitop/lua-bitop.spec SRPM URL: https://tkrizek.fedorapeople.org/lua-bitop/lua-bitop-1.0.2-4.fc29.src.rpm Description: Lua BitOp is a C extension module for Lua 5.1/5.2 which adds bit-wise operations on numbers. Fedora Account System Username: tkrizek
COPR build: https://copr.fedorainfracloud.org/coprs/tkrizek/lua/build/879756/ I wasn't able to create debugsource for Fedora, so I've disabled it. Then I ran into this rpmlint issue that might be related, but I wasn't able to fix it either: $ fedpkg --release f29 lint compat-lua-bitop.x86_64: W: unstripped-binary-or-object /usr/lib64/lua/5.1/bit.so 2 packages and 1 specfiles checked; 0 errors, 1 warnings.
I'm not able to run fedora-review on Fedora 29. First I needed to disable one of my repositories that mock is able to install packages and dnf repoquery throws an exception. However in the install section please create directory with an extra install call, e.g.: install -d -m 0755 %{buildroot}%{luacompatlibdir} and for LUALIB please use a %global and define it at the beginning of the spec file.
Changed spec as suggested above. Andreas, feel free to leave the formal review to some else if you have issues with the tool. A colleague of mine will be reviewing the other lua packages I've created anyway.
(In reply to Andreas Schneider from comment #2) > I'm not able to run fedora-review on Fedora 29. First I needed to disable > one of my repositories that mock is able to install packages and dnf > repoquery throws an exception. > > However in the install section please create directory with an extra install > call, e.g.: > > install -d -m 0755 %{buildroot}%{luacompatlibdir} > > > and for LUALIB please use a %global and define it at the beginning of the > spec file. Use fedora-review 0.7.1 from updates-testing. I've changed the way repoquery is run (now everything is in the chroot). Onto the review: # NOTE: for some reason, debugsourcefiles.list is empty when building on Fedora, # even though -g is present in CFLAGS %global debug_package %{nil} This needs some investigation. This is probably related to: %install %if 0%{?fedora} || 0%{?rhel} > 7 install -d -m 0755 %{buildroot}%{luacompatlibdir} install -m 0644 bit.so %{buildroot}%{luacompatlibdir}/bit.so %else install -d -m 0755 %{buildroot}%{lualibdir} install -m 0644 bit.so %{buildroot}%{lualibdir}/bit.so %endif .so needs to be executables to be properly stripped. Use -m 0755. - Use install -p to keep timestamps - use %make_build to build in // - Also set up Fedora default flags LDFLAGS="%{build_ldflags} $(pkg-config --libs %{lualib})" - -g -s is already set in optflags, no need to repeat it - Be more specific in %files %if 0%{?rhel} && 0%{?rhel} <= 7 %files %doc README %{lualibdir}/bit.so %endif %if 0%{?fedora} || 0%{?rhel} > 7 %files -n compat-%{name} %doc README %{luacompatlibdir}/bit.so %endif Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/lua-bitop See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 18 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/lua-bitop/review-lua-bitop/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in compat- lua-bitop [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: compat-lua-bitop-1.0.2-4.fc31.x86_64.rpm lua-bitop-debugsource-1.0.2-4.fc31.x86_64.rpm lua-bitop-1.0.2-4.fc31.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
I've fixed the issue mentioned above, please see update spec.
LGTM, package approved.