Description of problem: I am packaging xonsh 0.8.12 for Fedora 29. When I launch xonsh, I get the following output: $ /bin/xonsh /usr/lib/python3.7/site-packages/prompt_toolkit/styles/from_dict.py:9: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working from collections import Mapping carmen@carmen-thinkpad ~/Projektoj/xonsh.bak f30 $ Version-Release number of selected component (if applicable): 1.0.15-1 How reproducible: Steps to Reproduce: 1. Launch 2. Run the following commands: >>> import warnings >>> warnings.filterwarnings('always', category=DeprecationWarning) >>> import prompt_toolkit.styles.from_dict Actual results: You get the following deprecation warning: /usr/lib/python3.7/site-packages/prompt_toolkit/styles/from_dict.py:9: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working from collections import Mapping Expected results: You get no deprecation warning. Additional info:
Submitted a fix at https://src.fedoraproject.org/rpms/python-prompt_toolkit/pull-request/2
I can reproduce the error. Good news is in F30 we've switched to prompt_toolkit 2, which as best I can tell no longer imports collections.Mapping anywhere. Have you reported this upstream? They have a 1.0 branch, which would be the ideal way to fix this. If upstream ignores or refuses then your pull request to add a patch looks fine, but we need to try upstream first.
The upstream 1.0 branch hasn't been maintained/updated as far as I can see. I'll report the bug upstream and send a link to bz, but I doubt there'll be a release.
https://github.com/prompt-toolkit/python-prompt-toolkit/issues/871
Thanks for reporting the issue upstream. Per the guidelines we should at least try. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment I imagine for such a trivial fix upstream will fix it in the 1.0 branch and maybe even tag a 1.0.16 for us. If we haven't heard back by next week I'll go ahead and merge your pull request.
Understandable. Thank you for letting me know.
I see upstream has added the fix to the 1.0 branch and tagged 1.0.16. Would you like to change your pull request to update to that version instead of adding a patch? If not I can just close it and take care of the update myself.
If you have time to do that, that's good. Otherwise it'll take me a few days to find time to verify 1.0.16 and alter the PR.
python-prompt_toolkit-1.0.16-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ab10789cd2
python-prompt_toolkit-1.0.16-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ab10789cd2
python-prompt_toolkit-1.0.16-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.