Bug 1697844
| Summary: | [NMCI] team_abs_overwrite_watchers test fail | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Vladimir Benes <vbenes> |
| Component: | NetworkManager | Assignee: | Francesco Giudici <fgiudici> |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.6 | CC: | atragler, bgalvani, fgiudici, lrintel, rkhan, sukulkar, thaller |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | NetworkManager-1.18.0-2.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-08-06 13:16:46 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Vladimir Benes
2019-04-09 08:00:18 UTC
All the NetworkManager array properties but the link_watcher ones: - bridge.vlans - bridge-port.vlans - ipv[46].addresses - ipv[46].routes - sriov.vfs - tc.qdiscs - tc.tfilters will add the value when performing a "set" in nmcli interactive (editor) mode. While we can argue if a "set" operation in interactive mode should add or overwrite the value by default (for the record I would be for the latter), we should behave consistently: the link_watcher property should add to the value when performing a "set" in nmcli interactive mode. I would change the test to check link_watcher for a consistent behavior and would consider previous behavior as buggy. > While we can argue if a "set" operation in interactive mode should add or overwrite the value by default (for the record I would be for the latter), we should behave consistently: the link_watcher property should add to the value when performing a "set" in nmcli interactive mode.
That is not really the question. The new behaviour makes more sense and is fine.
The problem is,
- I tried not to change behaviour when refactoring nmcli, but ended breaking the test (why?)
- I tried to reproduce the previous behaviour on may machine (with an older branch before my changes), but was unable to even get the old behaviour passing. IOW, I don't understand how this test was ever passing (why?)
Need to git-bisect this issue again, but I failed to do so the last time because I didn't find a "good" version (with old behaviour).
(In reply to Thomas Haller from comment #3) > [..] > > The problem is, > > - I tried not to change behaviour when refactoring nmcli, but ended > breaking the test (why?) I guess it > > - I tried to reproduce the previous behaviour on may machine (with an older > branch before my changes), but was unable to even get the old behaviour > passing. IOW, I don't understand how this test was ever passing (why?) > The change in behavior seems due to the commit: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=4e7eadd6d3425f301277448329d53e93b09236b9 Let's update the test for nm version 1.17.2 and above. test changed upstream working as expected Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:2302 |