RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1697844 - [NMCI] team_abs_overwrite_watchers test fail
Summary: [NMCI] team_abs_overwrite_watchers test fail
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: NetworkManager
Version: 7.6
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Francesco Giudici
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-09 08:00 UTC by Vladimir Benes
Modified: 2019-08-06 13:17 UTC (History)
7 users (show)

Fixed In Version: NetworkManager-1.18.0-2.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-06 13:16:46 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:2302 0 None None None 2019-08-06 13:17:03 UTC

Description Vladimir Benes 2019-04-09 08:00:18 UTC 
Description of problem:
test failing

https://desktopqe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/beaker-NetworkManager-veth-RHEL-7.7/11/artifact/artifacts/FAIL_report_NetworkManager-ci_Test173_team_abs_overwrite_watchers.html
Version-Release number of selected component (if applicable):


How reproducible:
1.18
Comment 2 Francesco Giudici 2019-04-30 09:57:36 UTC 
All the NetworkManager array properties but the link_watcher ones:
- bridge.vlans
- bridge-port.vlans
- ipv[46].addresses
- ipv[46].routes
- sriov.vfs
- tc.qdiscs
- tc.tfilters

will add the value when performing a "set" in nmcli interactive (editor) mode.
While we can argue if a "set" operation in interactive mode should add or overwrite the value by default (for the record I would be for the latter), we should behave consistently: the link_watcher property should add to the value when performing a "set" in nmcli interactive mode.

I would change the test to check link_watcher for a consistent behavior and would consider previous behavior as buggy.
Comment 3 Thomas Haller 2019-05-02 11:05:34 UTC 
> While we can argue if a "set" operation in interactive mode should add or overwrite the value by default (for the record I would be for the latter), we should behave consistently: the link_watcher property should add to the value when performing a "set" in nmcli interactive mode.

That is not really the question. The new behaviour makes more sense and is fine.

The problem is,

 - I tried not to change behaviour when refactoring nmcli, but ended breaking the test (why?)

 - I tried to reproduce the previous behaviour on may machine (with an older branch before my changes), but was unable to even get the old behaviour passing. IOW, I don't understand how this test was ever passing (why?)


Need to git-bisect this issue again, but I failed to do so the last time because I didn't find a "good" version (with old behaviour).
Comment 4 Francesco Giudici 2019-05-03 10:03:33 UTC 
(In reply to Thomas Haller from comment #3)
> [..]
> 
> The problem is,
> 
>  - I tried not to change behaviour when refactoring nmcli, but ended
> breaking the test (why?)

I guess it
> 
>  - I tried to reproduce the previous behaviour on may machine (with an older
> branch before my changes), but was unable to even get the old behaviour
> passing. IOW, I don't understand how this test was ever passing (why?)
> 

The change in behavior seems due to the commit:
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=4e7eadd6d3425f301277448329d53e93b09236b9

Let's update the test for nm version 1.17.2 and above.
Comment 5 Francesco Giudici 2019-05-03 10:33:00 UTC 
https://github.com/NetworkManager/NetworkManager-ci/pull/329
Comment 6 Francesco Giudici 2019-05-03 15:00:45 UTC 
test changed upstream
Comment 8 Vladimir Benes 2019-05-13 12:44:36 UTC 
working as expected
Comment 10 errata-xmlrpc 2019-08-06 13:16:46 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2302
Note You need to log in before you can comment on or make changes to this bug.