Bug 1699432 - appliance-creator crash in setting up grub-legacy
Summary: appliance-creator crash in setting up grub-legacy
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: livecd-tools
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: RejectedFreezeException
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-12 17:03 UTC by Kevin Fenzi
Modified: 2019-04-27 21:24 UTC (History)
9 users (show)

Fixed In Version: livecd-tools-27.0-1.fc29 livecd-tools-27.1-1.fc29 livecd-tools-27.1-1.fc28 livecd-tools-27.1-1.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-04-27 21:24:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Kevin Fenzi 2019-04-12 17:03:12 UTC
Rawhide compose failed today due to: 

https://koji.fedoraproject.org/koji/taskinfo?taskID=34122673

Which has:

DEBUG util.py:439:  Writing GRUB Legacy config.
DEBUG util.py:439:   
DEBUG util.py:439:  Traceback (most recent call last):
DEBUG util.py:439:    File "/usr/bin/appliance-creator", line 193, in <module>
DEBUG util.py:439:      sys.exit(main())
DEBUG util.py:439:    File "/usr/bin/appliance-creator", line 155, in main
DEBUG util.py:439:      creator.configure()
DEBUG util.py:439:    File "/usr/lib/python3.7/site-packages/imgcreate/creator.py", line 801, in configure
DEBUG util.py:439:      self._create_bootconfig()
DEBUG util.py:439:    File "/usr/lib/python3.7/site-packages/appcreate/appliance.py", line 536, in _create_bootconfig
DEBUG util.py:439:      self._create_grub_config()
DEBUG util.py:439:    File "/usr/lib/python3.7/site-packages/appcreate/appliance.py", line 290, in _create_grub_config
DEBUG util.py:439:      kernels = self._get_kernel_versions()
DEBUG util.py:439:    File "/usr/lib/python3.7/site-packages/imgcreate/creator.py", line 320, in _get_kernel_versions
DEBUG util.py:439:      version = get_version(header)
DEBUG util.py:439:    File "/usr/lib/python3.7/site-packages/imgcreate/creator.py", line 309, in get_version
DEBUG util.py:439:      if f.startswith(b'/boot/vmlinuz-'):
DEBUG util.py:439:  TypeError: startswith first arg must be str or a tuple of str, not bytes

I'm not sure what changed, but https://bugzilla.redhat.com/show_bug.cgi?id=1693751 could be related?

Comment 1 Neal Gompa 2019-04-12 18:12:44 UTC
It does seem like it.

The relevant snippet[1] seems to indicate we expected bytes and now it returns strings, I need to adapt... :(


[1]: https://github.com/livecd-tools/livecd-tools/blob/master/imgcreate/creator.py#L308-L310

Comment 2 Kevin Fenzi 2019-04-12 21:46:57 UTC
ok. Any chance for a workaround/fix soon? rawhide composes are breaking currently due to this. ;(

Comment 3 Neal Gompa 2019-04-12 21:47:54 UTC
I'm looking into this now...

Comment 4 Neal Gompa 2019-04-13 02:04:51 UTC
I've made a fix(ish?) and built a new livecd-tools for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1248397

Can you check to see if that helps?

Comment 5 Kevin Fenzi 2019-04-13 03:04:12 UTC
Awesome. Thanks for the quick fix. I've fired off a new compose and we can see how it does...

Comment 6 Kevin Fenzi 2019-04-13 15:14:40 UTC
Worked! Thanks much!

Comment 7 Neal Gompa 2019-04-13 15:33:49 UTC
Excellent, then this is now fixed in Rawhide. :)

Comment 8 Fedora Update System 2019-04-16 21:48:17 UTC
livecd-tools-27.0-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-542e92f701

Comment 9 Fedora Update System 2019-04-16 21:49:05 UTC
livecd-tools-27.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b7690cea09

Comment 10 Fedora Update System 2019-04-16 21:49:42 UTC
livecd-tools-27.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-01f6acd429

Comment 11 Fedora Update System 2019-04-18 22:19:54 UTC
livecd-tools-27.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2019-04-19 15:14:48 UTC
livecd-tools-27.1-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-542e92f701

Comment 13 Fedora Update System 2019-04-19 15:28:20 UTC
livecd-tools-27.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b7690cea09

Comment 14 Fedora Update System 2019-04-19 15:29:28 UTC
livecd-tools-27.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b80b564a18

Comment 15 Fedora Update System 2019-04-19 15:54:27 UTC
livecd-tools-27.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-542e92f701

Comment 16 Fedora Update System 2019-04-19 18:16:01 UTC
livecd-tools-27.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b7690cea09

Comment 17 Fedora Update System 2019-04-19 20:36:06 UTC
livecd-tools-27.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b80b564a18

Comment 18 Fedora Update System 2019-04-21 05:04:32 UTC
livecd-tools-27.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Blocker Bugs Application 2019-04-21 05:41:09 UTC
Proposed as a Freeze Exception for 30-final by Fedora user ngompa using the blocker tracking app because:

 This fixes an issue caused by rpm's Python 3 API changing which breaks the production of ARM appliance images with appliance-creator. The fix is verified to work properly in Rawhide and I'd like it to be in F30 final base.

Comment 20 Fedora Update System 2019-04-21 22:39:41 UTC
livecd-tools-27.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 21 Geoffrey Marr 2019-04-22 18:34:17 UTC
Discussed during the 2019-04-22 blocker review meeting: [1]

The decision to classify this bug as a "RejectedFreezeException" was made as at this point we don't want to touch the compose creation tools unless absolutely necessary. What is in F30 currently is working for producing F30, we don't want to change it. This can be shipped as an update after launch.

[1] https://meetbot.fedoraproject.org/fedora-blocker-review/2019-04-22/f30-blocker-review.2019-04-22-16.00.txt

Comment 22 Fedora Update System 2019-04-27 21:24:38 UTC
livecd-tools-27.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.