Created attachment 1555806 [details]
engine-setup log

Description of problem:

oVirt engine upgrade fails schema refresh when updating 4.3.2.1 -> 4.3.3


Version-Release number of selected component (if applicable): 4.3.2.1-1.el7


How reproducible:
Should be happening on v4.3.2 engines upon upgrade to v4.3.3

Steps to Reproduce:
1. run engine-setup on a v4.3.2 engine instance
2. allow upgrade procedure to occur

Actual results:

[ INFO  ] Stage: Misc configuration
[ INFO  ] Upgrading CA
[ INFO  ] Creating PostgreSQL 'ovirt_engine_history' database
[ INFO  ] Configuring PostgreSQL
[ INFO  ] Creating/refreshing DWH database schema
[ INFO  ] Configuring Image I/O Proxy
[ INFO  ] Configuring WebSocket Proxy
[ INFO  ] Backing up database localhost:engine to '/var/lib/ovirt-engine/backups/engine-20190417110419.32VRLE.dump'.
[ INFO  ] Creating/refreshing Engine database schema
[ ERROR ] schema.sh: FATAL: Cannot execute sql command: --file=/usr/share/ovirt-engine/dbscripts/upgrade/04_03_0830_add_foreign_key_to_image_transfers.sql
[ ERROR ] Failed to execute stage 'Misc configuration': Engine schema refresh failed

Expected results:

Successful update

Additional info:

After some digging, I think I have found the root cause for this error:

oVirt 4.3.2 schema refresh scripts:
/usr/share/ovirt-engine/dbscripts/upgrade/04_03_0265_remove_foreign_key_in_image_transfers.sql
/usr/share/ovirt-engine/dbscripts/upgrade/04_03_0270_add_foreign_key_to_image_transfers.sql

oVirt 4.3.3 schema refresh scripts:
/usr/share/ovirt-engine/dbscripts/upgrade/04_03_0830_add_foreign_key_to_image_transfers.sql

The constraint name added/removed in v4.3.2 refresh scripts has a typo "fk_image_transfers_command_enitites" vs "fk_image_transfers_command_entities":

ALTER TABLE ONLY image_transfers ADD CONSTRAINT fk_image_transfers_command_enitites FOREIGN KEY (command_id) REFERENCES command_entities(command_id) ON DELETE CASCADE;