Spec URL: https://fedorapeople.org/~jwrdegoede/mx5000tools.spec SRPM URL: https://fedorapeople.org/~jwrdegoede/mx5000tools-0.1.2-1.20190407git4967881.fc30.src.rpm Description: mx5000tools are tools to control the extra features on the Logitech MX 5000 bluetooth cordless keyboard. Fedora Account System Username: jwrdegoede
Just some minutes for rebuilding.
I was curious so I took a quick look: Typo in %description appsd -> applications The copyright for the revoco.c file is somewhat concerning, perhaps Spot should take a look.
(In reply to Simo Sorce from comment #2) > I was curious so I took a quick look: > > Typo in %description appsd -> applications > > The copyright for the revoco.c file is somewhat concerning, perhaps Spot > should take a look. A valid concern. We don't use any of the files under the revoLUTIONconTROL dir. It looks like I'm going to be the new upstream for mx5000tools and I've no plans for the revoLUTIONconTROL stuff, it is just in my github repo for this since I started by cloning an existing github mirror which has this. So for the next package version I will remove the revoLUTIONconTROL stuff from my github repo for this and use a new git snapshot with just the mx5000tools stuff in there.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ GCC is not listed as BR package but it's automatically required by libtool - Remove Group - Please add '%ldconfig_scriptlets libs' is you want to build even for EPEL. - revoLUTIONconTROL/ 's license is pending ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "Creative Commons CC0 Public License (v1)", "Unknown or generated". 16 files have unknown license. Detailed output of licensecheck in /home/sagitter/FedoraReview/1701242-mx5000tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mx5000tools-libs , mx5000tools-devel [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mx5000tools-0.1.2-1.20190407git4967881.fc31.x86_64.rpm mx5000tools-libs-0.1.2-1.20190407git4967881.fc31.x86_64.rpm mx5000tools-devel-0.1.2-1.20190407git4967881.fc31.x86_64.rpm mx5000tools-debuginfo-0.1.2-1.20190407git4967881.fc31.x86_64.rpm mx5000tools-debugsource-0.1.2-1.20190407git4967881.fc31.x86_64.rpm mx5000tools-0.1.2-1.20190407git4967881.fc31.src.rpm mx5000tools.x86_64: W: spelling-error %description -l en_US bluetooth -> Bluetooth, blue tooth, blue-tooth mx5000tools.x86_64: W: no-documentation mx5000tools.x86_64: W: no-manual-page-for-binary mx5000-tool mx5000tools-libs.x86_64: W: spelling-error %description -l en_US appsd -> apps, apps d, apposed mx5000tools-libs.x86_64: W: spelling-error %description -l en_US bluetooth -> Bluetooth, blue tooth, blue-tooth mx5000tools-devel.x86_64: W: no-documentation mx5000tools-devel.x86_64: E: incorrect-fsf-address /usr/include/libmx5000/mx5000.h mx5000tools-devel.x86_64: E: incorrect-fsf-address /usr/include/libmx5000/mx5000screencontent.h mx5000tools.src: W: spelling-error %description -l en_US bluetooth -> Bluetooth, blue tooth, blue-tooth 6 packages and 0 specfiles checked; 2 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: mx5000tools-libs-debuginfo-0.1.2-1.20190407git4967881.fc31.x86_64.rpm mx5000tools-debuginfo-0.1.2-1.20190407git4967881.fc31.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sh: /usr/bin/python: No such file or directory /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') mx5000tools-devel.x86_64: W: invalid-url URL: https://github.com/jwrdegoede/mx5000tools-revo <urlopen error [Errno -2] Name or service not known> mx5000tools-devel.x86_64: W: no-documentation mx5000tools-devel.x86_64: E: incorrect-fsf-address /usr/include/libmx5000/mx5000.h mx5000tools-devel.x86_64: E: incorrect-fsf-address /usr/include/libmx5000/mx5000screencontent.h mx5000tools-debugsource.x86_64: W: invalid-url URL: https://github.com/jwrdegoede/mx5000tools-revo <urlopen error [Errno -2] Name or service not known> mx5000tools.x86_64: W: spelling-error %description -l en_US bluetooth -> Bluetooth, blue tooth, blue-tooth mx5000tools.x86_64: W: invalid-url URL: https://github.com/jwrdegoede/mx5000tools-revo <urlopen error [Errno -2] Name or service not known> /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') mx5000tools.x86_64: W: no-documentation mx5000tools.x86_64: W: no-manual-page-for-binary mx5000-tool mx5000tools-libs-debuginfo.x86_64: W: invalid-url URL: https://github.com/jwrdegoede/mx5000tools-revo <urlopen error [Errno -2] Name or service not known> /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') mx5000tools-debuginfo.x86_64: W: invalid-url URL: https://github.com/jwrdegoede/mx5000tools-revo <urlopen error [Errno -2] Name or service not known> /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') mx5000tools-libs.x86_64: W: spelling-error %description -l en_US appsd -> apps, apps d, apposed mx5000tools-libs.x86_64: W: spelling-error %description -l en_US bluetooth -> Bluetooth, blue tooth, blue-tooth mx5000tools-libs.x86_64: W: invalid-url URL: https://github.com/jwrdegoede/mx5000tools-revo <urlopen error [Errno -2] Name or service not known> /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') 6 packages and 0 specfiles checked; 2 errors, 12 warnings. Requires -------- mx5000tools-debuginfo (rpmlib, GLIBC filtered): mx5000tools-devel (rpmlib, GLIBC filtered): libmx5000.so.0()(64bit) mx5000tools-libs(x86-64) mx5000tools (rpmlib, GLIBC filtered): libc.so.6()(64bit) libmx5000.so.0()(64bit) mx5000tools-libs(x86-64) rtld(GNU_HASH) mx5000tools-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libnetpbm.so.11()(64bit) rtld(GNU_HASH) mx5000tools-debugsource (rpmlib, GLIBC filtered): Provides -------- mx5000tools-debuginfo: debuginfo(build-id) mx5000tools-debuginfo mx5000tools-debuginfo(x86-64) mx5000tools-devel: mx5000tools-devel mx5000tools-devel(x86-64) mx5000tools: mx5000tools mx5000tools(x86-64) mx5000tools-libs: libmx5000.so.0()(64bit) mx5000tools-libs mx5000tools-libs(x86-64) mx5000tools-debugsource: mx5000tools-debugsource mx5000tools-debugsource(x86-64) Source checksums ---------------- https://github.com/jwrdegoede/mx5000tools-revo/archive/496788107a915f94c2e17a86d937f0ac10e6cf80/mx5000tools-4967881.tar.gz : CHECKSUM(SHA256) this package : 5d6a556fade031c6d6d6b6bca21528ad087c27e1171f3e81a19bf7388fc6b70f CHECKSUM(SHA256) upstream package : 5d6a556fade031c6d6d6b6bca21528ad087c27e1171f3e81a19bf7388fc6b70f AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: mx5000tools-revo- 496788107a915f94c2e17a86d937f0ac10e6cf80/mx5000tools/configure.ac:10 Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :./try-fedora-review -m fedora-rawhide-x86_64 -b 1701242 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, BATCH, EPEL7, EPEL6
Antonio, thank you for the fast review. I have no plans to ever build this for EPEL, nor do I really expect others to, so I've chosen to not add '%ldconfig_scriptlets libs'. All other items should be addressed in the new version, including most rpmlint warnings: Spec URL: https://fedorapeople.org/~jwrdegoede/mx5000tools.spec SRPM URL: https://fedorapeople.org/~jwrdegoede/mx5000tools-0.1.2-2.20190418git59d929d.fc30.src.rpm
Approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mx5000tools
Imported and now building for f29+. Antonio, once more: thank you. If you want me review a package in return drop me a direct email. If you reply to the mail on fedora-devel I'm afraid I might miss it.
mx5000tools-0.1.2-2.20190418git59d929d.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-352f3cf5bc
mx5000tools-0.1.2-2.20190418git59d929d.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f7fd813767
mx5000tools-0.1.2-2.20190418git59d929d.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-352f3cf5bc
mx5000tools-0.1.2-2.20190418git59d929d.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
mx5000tools-0.1.2-2.20190418git59d929d.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.