Bug 1701314

Description of problem:
When executing sapconf on RHEL 8, avoiding call to check_rpms() (line 998) to avoid BZ 1670494, the following error message is shown:
grep: Unmatched ( or \(

Version-Release number of selected component (if applicable):
0.98

How reproducible:
see Steps to Reproduce

Steps to Reproduce:
1. Install RHEL 8 Minimal Environment or Server
2. Install the sapconf package (sapconf-0.98-15.el8.noarch.rpm). Dependencies:
   dnf-utils-4.0.2.2-3.el8.noarch
   tuned-profiles-sap-2.10.0-14.el8.noarch
3. Uncomment the call to check_rpms() (line 999) to avoid BZ 1670494 .
4. Execute sapconf

Actual results:
The following lines are shown:
# /usr/bin/sapconf
######    	sapconf-0.98-15  by Red Hat   	######
###### Preparing System for SAP Installation  ######

grep: Unmatched ( or \(
Failed to set locale, defaulting to C
RHEL system not subscribed to RHEL for SAP channel ... WARNING
/etc/sysconfig/network settings ... OK

This error occurs if the number of fields in /etc/redhat-release is different compared to RHEL 7. Example:

# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.6 (Maipo)

# cat /etc/redhat-release
Red Hat Enterprise Linux release 8.0 (Ootpa)

So if the release number in /etc/redhat-release is always the second last one, we can avoid this problem by using awk $(NF-1) to select the release number. We also can use awk instead of cut to select the major release number.

Note that as per https://docs.engineering.redhat.com/pages/viewpage.action?spaceKey=RHELPLAN&title=SAP+Offerings , the name of the repo changes in RHEL 8 as well. The new name is now:
rhel-8-for-{x86_64-|ls390x-|ppc64le-}sap-netweaver-{beta-|e4s-|els-}rpms

Expected results:
Same as above but without the line containing the string "Unmatched ( or \("

This error can be avoided while keeping the same functionality as before by changing the first line of function check_rhn():
--->
if yum repolist | egrep -q "rhel-$(uname -m)-server-sap|rhel-sap-for-rhel-$(awk '{print $7}' /etc/redhat-release | cut -c -1)-server(-e4s|-eus)?-rpms"; then
<---
to:
--->
yum repolist | egrep "rhel-$(uname -m)-server-sap|rhel-sap-for-rhel-$(awk '{split($(NF-1), a, "."); print a[1]}' /etc/redhat-release)-server(-e4s|-eus)?-rpms"
<---

This will work on RHEL 7, and the egrep search pattern will be:
rhel-x86_64-server-sap|rhel-sap-for-rhel-7-server(-e4s|-eus)?-rpms

For RHEL 8, if we want to search for the new name rhel-8-for-{x86_64-|ls390x-|ppc64le-}sap-netweaver-{beta-|e4s-|els-}rpms, we would likely have to construct the egrep pattern as follows:

# echo "rhel-$(awk '{split($(NF-1), a, "."); print a[1]}' /etc/redhat-release)-for-$(uname -m)-sap-netweaver(-beta|-e4s|-eus)?-rpms"

Sample output on RHEL 7:
rhel-7-for-x86_64-sap-netweaver(-beta|-e4s|-eus)?-rpms

Sample output on RHEL 8:
rhel-8-for-x86_64-sap-netweaver(-beta|-e4s|-eus)?-rpms

With this, the new line for yum repolist in sapconf would be:
--->
yum repolist | egrep "rhel-$(awk '{split($(NF-1), a, "."); print a[1]}' /etc/redhat-release)-for-$(uname -m)-sap-netweaver(-beta|-e4s|-eus)?-rpms"
<---

Additional info:
To test and verify the solution, you may execute:
# echo "Red Hat Enterprise Linux release 8.0 (Ootpa)" | awk '{split($(NF-1), a, "."); print a[1]}'
8
# echo "Red Hat Enterprise Linux release 10.0 (XXX)" | awk '{split($(NF-1), a, "."); print a[1]}'
10
# echo "Red Hat Enterprise Linux Server release 100.0 (XXX)" | \
awk '{split($(NF-1), a, "."); print a[1]}'
100
# echo "RHEL 9.4 (XXX)" | awk '{split($(NF-1), a, "."); print a[1]}'
9