Bug 1701829 - Thunar tree / folder view moves when selecting folders, making Thunar completely disorienting and unusable.
Summary: Thunar tree / folder view moves when selecting folders, making Thunar complet...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Thunar
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mukundan Ragavan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-22 06:57 UTC by BugMasta
Modified: 2019-08-15 22:14 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-08-15 22:14:53 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Xfce 15313 0 None None None 2019-06-30 06:35:20 UTC

Description BugMasta 2019-04-22 06:57:34 UTC
Description of problem:

Thunar is practically unusable on F29.

The current version, 1.8.4 has a bug in which the folder/tree view pane moves, when you select a folder in the view. This should not happen. It does not happen in earlier versions of Thunar. In earlier versions, the tree pane does not move unless you scroll up or down.

The folder view pane MUST NOT MOVE, when you are expanding folders or selecting folders. It Absolutely MUST NOT move. 

It is incredibly disorienting, if you select or expand something, and then the entire tree moves underneath your mouse. You completely lose track of where you are and what you were looking at.

I repeat. The tree/folder pane MUST NOT MOVE. 


Version-Release number of selected component (if applicable):

1.8.4

How reproducible:

easily.

Steps to Reproduce:
1. Open Thnar, switch to tree/folder view in the left pane.
2. Expand some folders so there are bunch of folders that dont fit on the screen, so a scrollbar appears.
3. Select a folder here or there in the tree view, and behold, as the tree view moves up and down...

Actual results:

Tree view moves.

Expected results:

Tree view does not move.

Additional info:

As if this bug isn't bad enough, and it is, believe me... it is just impossible to navigate around deep folder trees or trees with lots of subfolders, when the folder view is moving of its own acord. It is impossible...

But... in addition to this bug, if i downgrade Thunar to the other version available in f29, Thunar 1.8.1 - i hit another bug with Thunar ignoring the Adwaita-Dark theme that i have set. So, suddenly, i have a white Thunar glaring at me, completely blinding me. It is appalling.

The combination of these two bugs means Thunar is completely unusable currently, on f29.

Pls fix... ASAP.

Comment 1 BugMasta 2019-04-22 07:06:20 UTC
I have also created a bug for this on the Xfce bugzilla.
https://bugzilla.xfce.org/show_bug.cgi?id=15313

I don't care how or who fixes this but pls, someone, somewhere, fix this.

Comment 2 Mukundan Ragavan 2019-04-22 20:23:25 UTC
I am unable to reproduce this on Fedora 30 (assuming I understand your concern correctly). Let's see what upstream says.

Comment 3 Mukundan Ragavan 2019-04-23 01:23:47 UTC
Can you try these builds and let me know if they fix your issue?

for F29 - https://koji.fedoraproject.org/koji/taskinfo?taskID=34349581


for F30 - https://koji.fedoraproject.org/koji/taskinfo?taskID=34349616

Comment 4 BugMasta 2019-04-23 11:39:31 UTC
Yep your build for f29 fixes it. I tried the x64 one.

Thank u so much Mukundan, for looking into this.
Pls ensure this fix gets into the upstream code asap!

Comment 5 BugMasta 2019-04-23 12:18:55 UTC
No wait,

Theo over on the xfce bugzilla:
  https://bugzilla.xfce.org/show_bug.cgi?id=15174
has pointed out that with this fix, if you click on Trash, then the mousecursor locks and you cant select any other folder.

So the fix has introduced a new bug.

Nevertheless, a solid fix must be very close.

I know you guys are close, so i am eagerly awaiting a solid fix.

Thanks to everyone for their efforts!

Comment 6 Mukundan Ragavan 2019-04-23 22:06:18 UTC
I started following 15174. I will push an update once there is a resolution.

Comment 7 Mukundan Ragavan 2019-04-24 22:00:33 UTC
Please try this build and let me know if it fixes your issue.


F29 - https://koji.fedoraproject.org/koji/taskinfo?taskID=34395406

F30 - https://koji.fedoraproject.org/koji/taskinfo?taskID=34395468

Comment 8 BugMasta 2019-04-27 05:51:08 UTC
Hi Mukundan,

I've tried your new package! 
And it does fix the original scrolling issue, and also the Trash bug.

Unfortuntely it seems to introduce one more new bug!
Now, when i click on a folder in the tree view, it gets expanded in the tree view, if it has subfolders.

That never used to happen before.
Before, when you select a folder in the tree view, it opens in the details pane on the right, but the subfolders do not get expanded in the tree view.

To expand a folder in the tree view, you had to click the arrow to the left of folder, which is how it should stay!

If you can go back to the old behavior, and stop tree view from expanding when u select a folder, that would be the best.

Many thanks!
John

Comment 9 Mukundan Ragavan 2019-04-27 10:52:46 UTC
Glad to hear the scrolling bug is fixed.

(In reply to BugMasta from comment #8)
> 
> To expand a folder in the tree view, you had to click the arrow to the left
> of folder, which is how it should stay!

I think you are mis-remembering. Clicking on a folder does expand the tree even in unpatched version. I just confirmed it on a virtual machine I have. This is certainly not new (at least as far as I can tell).

Comment 10 Mukundan Ragavan 2019-04-27 10:55:28 UTC
Oh wait - I see what you are describing in a Fedora 28 VM! That was GTK2 Thunar.

That said, this needs to be a different bug. I will submit an update for this fix. Would you like to open an upstream bug report for this (tree view non expanding unless explicitly expanded)?

Comment 11 Fedora Update System 2019-05-01 22:18:25 UTC
Thunar-1.8.4-5.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5307c1e977

Comment 12 Fedora Update System 2019-05-01 22:18:30 UTC
Thunar-1.8.4-5.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-77eb2a186c

Comment 13 Fedora Update System 2019-05-02 02:38:33 UTC
Thunar-1.8.4-5.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5307c1e977

Comment 14 Fedora Update System 2019-05-02 02:59:47 UTC
Thunar-1.8.4-5.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-77eb2a186c

Comment 15 BugMasta 2019-05-02 14:30:49 UTC
(In reply to Mukundan Ragavan from comment #10)
> Oh wait - I see what you are describing in a Fedora 28 VM! That was GTK2
> Thunar.
> 
> That said, this needs to be a different bug. I will submit an update for
> this fix. Would you like to open an upstream bug report for this (tree view
> non expanding unless explicitly expanded)?

Yeah i think i will submit another bug for the tree view expanding :-)

I find it really tiresome, selecting a folder in tree view should show contents in right pane and not expand tree view. That's how windows explorer works (and explorer is deficient in many ways, but, it got this right) and even with Thunar, the auto-expand behaviour may've appeared a while ago, after GTK2 thunar, but it then got disabled apparently as a side effect, and that is they way it should stay :-)

Or as dev alex has suggested, have a setting so users can turn it on/off as they desire.
But yeah, it's not as big a deal as this scrolling bug, but, i still don't like it at all...

Ty Mukundan for getting these patched rpms out so fast, i am very happy this scroll bug has been fixed, that was an absolute bastard... :-)

Comment 16 Fedora Update System 2019-05-17 01:04:01 UTC
Thunar-1.8.4-5.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2019-05-17 03:17:05 UTC
Thunar-1.8.4-5.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.