Spec URL: https://bowlofeggs.fedorapeople.org/python-pyramid_sawing.spec SRPM URL: https://bowlofeggs.fedorapeople.org/python-pyramid_sawing-1.1.3-1.fc31.src.rpm Description: A Pyramid framework plugin for configurating logging via YAML. This uses the Python standard-library's logging (initialized using logging.config.dictConfig). Fedora Account System Username: bowlofeggs
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [!]: Spec file is legible and written in American English. --> description uses "configurating" instead of "configuring" (see rpmlint output below) [-]: Package contains systemd file(s) if needed. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [!]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. --> needs BR: python3-pyramid, python3-pyyaml for running the tests [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x/!]: Final provides and requires are sane (see attachments). --> (Only) if you want to have this package on Fedora < 30, you need to add the %{?python_enable_dependency_generator} macro (or add the runtime dependencies manually): https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. --> see above (BRs) [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-pyramid_sawing-1.1.3-1.fc31.noarch.rpm python-pyramid_sawing-1.1.3-1.fc31.src.rpm python3-pyramid_sawing.noarch: W: spelling-error %description -l en_US configurating -> configuration, confiscating, congratulating python3-pyramid_sawing.noarch: W: spelling-error %description -l en_US dictConfig -> confiding python-pyramid_sawing.src: W: spelling-error %description -l en_US configurating -> configuration, confiscating, congratulating python-pyramid_sawing.src: W: spelling-error %description -l en_US dictConfig -> confiding 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- python3-pyramid_sawing.noarch: W: spelling-error %description -l en_US configurating -> configuration, confiscating, congratulating python3-pyramid_sawing.noarch: W: spelling-error %description -l en_US dictConfig -> confiding python3-pyramid_sawing.noarch: W: invalid-url URL: https://github.com/openstax/pyramid_sawing <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://github.com/openstax/pyramid_sawing/archive/v1.1.3/pyramid_sawing-1.1.3.tar.gz : CHECKSUM(SHA256) this package : 7900d9d20139c5407d3cb65e560c11b021767ae21054536cc919f9924e67a21e CHECKSUM(SHA256) upstream package : 7900d9d20139c5407d3cb65e560c11b021767ae21054536cc919f9924e67a21e Requires -------- python3-pyramid_sawing (rpmlib, GLIBC filtered): python(abi) python3.7dist(pyramid) python3.7dist(pyyaml) Provides -------- python3-pyramid_sawing: python3-pyramid_sawing python3.7dist(pyramid-sawing) python3dist(pyramid-sawing) Summary ------- - misspelled word in the description - missing BRs for %check - depending on if Fedora < 30 should be supported, needs to enable the python dependency generator
Hi Nils! I've uploaded a new spec/SRPM to the same URL as before. This one should address all the issues you noted, except for the explicit requires. I do plan to bring this to Fedora 29, but I will add the explicit requires in the f29 branch when I do so.
Thanks for addressing the issues! The package is ACCEPTED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyramid_sawing
python-pyramid_sawing-1.1.3-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-46d769d8f0
python-pyramid_sawing-1.1.3-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8608c59737
python-pyramid_sawing-1.1.3-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8608c59737
python-pyramid_sawing-1.1.3-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-46d769d8f0
python-pyramid_sawing-1.1.3-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
python-pyramid_sawing-1.1.3-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.