Bug 1702497 - Datepicker Field Cannot be Set to Required
Summary: Datepicker Field Cannot be Set to Required
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.10.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.7
Assignee: Roman Blanco
QA Contact: Niyaz Akhtar Ansari
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On: 1692980
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-23 22:46 UTC by Satoe Imaishi
Modified: 2023-03-24 14:45 UTC (History)
12 users (show)

Fixed In Version: 5.10.7.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1692980
Environment:
Last Closed: 2019-07-24 13:38:52 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
disabled button (73.61 KB, image/png)
2019-04-29 19:04 UTC, Niyaz Akhtar Ansari
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:1833 0 None None None 2019-07-24 13:39:03 UTC

Comment 2 Satoe Imaishi 2019-04-24 11:49:45 UTC
The fix is included in ui-components 1.1.24

https://github.com/ManageIQ/manageiq-ui-classic/pull/5483
https://github.com/ManageIQ/manageiq-ui-service/pull/1541

Comment 3 CFME Bot 2019-04-24 19:48:13 UTC
New commit detected on ManageIQ/ui-components/hammer:

https://github.com/ManageIQ/ui-components/commit/10bdc766694f7f7f1deac99545544406f9ef3e3c
commit 10bdc766694f7f7f1deac99545544406f9ef3e3c
Author:     Martin Hradil <himdel>
AuthorDate: Tue Apr  9 06:37:35 2019 -0400
Commit:     Martin Hradil <himdel>
CommitDate: Tue Apr  9 06:37:35 2019 -0400

    Merge pull request #380 from romanblanco/bz1692980

    Allow datepicker field in service dialogs to be set as required

    (cherry picked from commit 1ba69228c75360f97c7f5a732bfd287d14fc2492)

    https://bugzilla.redhat.com/show_bug.cgi?id=1702497

 src/dialog-editor/components/modal-field-template/date-time-control.html | 15 +
 1 file changed, 15 insertions(+)

Comment 5 Niyaz Akhtar Ansari 2019-04-29 19:04:30 UTC
Created attachment 1560046 [details]
disabled button

Comment 15 CFME Bot 2019-07-02 20:29:52 UTC
New commit detected on ManageIQ/ui-components/hammer:

https://github.com/ManageIQ/ui-components/commit/0cdc27e97bdfcbda7aa192213bd6fac3f47e1e22
commit 0cdc27e97bdfcbda7aa192213bd6fac3f47e1e22
Author:     Martin Hradil <mhradil>
AuthorDate: Tue Jul  2 05:08:05 2019 -0400
Commit:     Martin Hradil <mhradil>
CommitDate: Tue Jul  2 05:08:05 2019 -0400

    Merge pull request #392 from romanblanco/bz1692863

    Mark datepicker field as valid only if it's value is an instance of Date

    (cherry picked from commit ffdd33d7ad457b2f6b895c690716b9bfc1b9bc89)

    https://bugzilla.redhat.com/show_bug.cgi?id=1702497
    https://bugzilla.redhat.com/show_bug.cgi?id=1726388

 src/dialog-user/services/dialogData.spec.ts | 7 +-
 src/dialog-user/services/dialogData.ts | 26 +-
 2 files changed, 25 insertions(+), 8 deletions(-)

Comment 17 Niyaz Akhtar Ansari 2019-07-10 08:22:48 UTC
Verification steps:

1. create a new service dialog with a datepicker field
2. add the service dialog to the catalog
3. in the service catalog select the service dialog and click on order
4. Clear the date from the field and enter "test" in the datepicker field

Expected Result:
Submit button should be disabled

Verifying this on_qa and will raise another BZ for different issue for same area 


Verified in  Version 5.10.7.0.20190709151852_68f0bf9

Comment 18 Niyaz Akhtar Ansari 2019-07-10 08:32:01 UTC
Raised Bug:

Please have a look
https://bugzilla.redhat.com/show_bug.cgi?id=1728600

Comment 20 errata-xmlrpc 2019-07-24 13:38:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:1833


Note You need to log in before you can comment on or make changes to this bug.