Spec URL: https://atim.fedorapeople.org/for-review/quilter.spec SRPM URL: https://atim.fedorapeople.org/for-review/quilter-1.8.4-1.20190425git5c7a1ca.fc30.src.rpm Description: Focus on your writing and write beautiful solid stories with the Focus Mode in tow in this Markdown editor. • Work on a story, one file at a time. • Save your documents anywhere, even on existing files. • Preview your story in the Preview Mode. • Configure whether to have Focus Mode or not. • Configure whether to have Dark Mode or not. • Configure whether to have Sepia Mode or not. • Fullscreen your writing area with F11. • Search anytime with the shortcut Ctrl + F. • Quit anytime with the shortcut Ctrl + Q. Fedora Account System Username: atim Working COPR: https://copr.fedorainfracloud.org/coprs/atim/quilter Waiting for upstream fix https://github.com/lainsce/quilter/issues/251 Also after next release will switch *Source* from git tarballs to release.
Hi! It's nice that you're working on officially packaging quilter for fedora. I'm already maintaining a COPR with elementary appcenter packages at [0], which you probably didn't see. Feel free to use my .spec files as inspiration (they might not be 100% up-to-date, but they do the job). For example, you need to be aware that - quilter bundles a few things, including highlight.js, - some things might not work as expected because you remove the included font, - and the "release date is in the future" thing is something this developer just does, even tough I've told him that it's weird multiple times, but he continues to do it. [0]: https://copr.fedorainfracloud.org/coprs/decathorpe/elementary-appcenter/monitor/
@Fabio, hah nice! I didnt seen this. > - quilter bundles a few things, including highlight.js, Oh, thats one of the most disappointment part for me. And *js-highlight.noarch* found in repos now, yep... > - some things might not work as expected because you remove the included font, Thats even worse news. > - and the "release date is in the future" thing is something this developer just does, even tough I've told him that it's weird multiple times, but he continues to do it. This makes me laugh. PS: I still cant find any good GTK Markdown editor with real time preview and available in main Fedora repos...
(In reply to Artem from comment #2) > Oh, thats one of the most disappointment part for me. And > *js-highlight.noarch* found in repos now, yep... It's one of the reasons why I didn't submit my package for review already. > > - some things might not work as expected because you remove the included font, > > Thats even worse news. You might have to check whether that font is actually used by the program, and how it uses it. Maybe it can be packaged as a "proper font package" for fedora, maybe not. > > - and the "release date is in the future" thing is something this developer just does, even tough I've told him that it's weird multiple times, but he continues to do it. > > This makes me laugh. Well, it makes me shake my head :) > PS: I still cant find any good GTK Markdown editor with real time preview > and available in main Fedora repos... I'm using either quilter (which has some issues) or ghostwriter (which works quite well, but it's using Qt, not GTK).
> It's one of the reasons why I didn't submit my package for review already. Did you ask him to unbundle it? > or ghostwriter Yep. Thats me who asked xvitaly to package it, but yep, this is Qt app. :)
- Why? rm %{buildroot}%{_datadir}/fonts/truetype/quilt/QuiltMono.ttf - Add BSD to the License field and a Provides: bundled(highlight.js) = 9.10.0 /*! highlight.js v9.10.0 | BSD3 License | git.io/hljslicense */ - Add OFL to the License field: https://github.com/lainsce/quilter/blob/master/data/font/SIL%20Open%20Font%20License.txt - Add a comment explaining the license breakdown Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)", "GPL (v2 or later)", "*No copyright* SIL Open Font License (v1.1)", "GNU Lesser General Public License (v2.1 or later)", "GPL (v2 or later) (with incorrect FSF address)", "Expat License". 85 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/quilter/review-quilter/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/icons/hicolor/64x64@2/apps, /usr/share/icons/hicolor/16x16@2, /usr/share/icons/hicolor/24x24@2/apps, /usr/share/icons/hicolor/32x32@2, /usr/share/icons/hicolor/24x24@2, /usr/share/icons/hicolor/48x48@2, /usr/share/icons/hicolor/32x32@2/apps, /usr/share/icons/hicolor/48x48@2/apps, /usr/share/icons/hicolor/64x64@2, /usr/share/icons/hicolor/16x16@2/apps, /usr/share/icons/hicolor/128x128@2, /usr/share/icons/hicolor/128x128@2/apps [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: quilter-1.8.4-1.20190425git5c7a1ca.fc31.x86_64.rpm quilter-debuginfo-1.8.4-1.20190425git5c7a1ca.fc31.x86_64.rpm quilter-debugsource-1.8.4-1.20190425git5c7a1ca.fc31.x86_64.rpm quilter-1.8.4-1.20190425git5c7a1ca.fc31.src.rpm quilter.x86_64: W: no-manual-page-for-binary com.github.lainsce.quilter quilter.src:60: W: macro-in-comment %{buildroot} quilter.src:60: W: macro-in-comment %{_metainfodir} quilter.src:60: W: macro-in-comment %{file_name} 4 packages and 0 specfiles checked; 0 errors, 4 warnings.
Spec URL: https://atim.fedorapeople.org/for-review/quilter.spec SRPM URL: https://atim.fedorapeople.org/for-review/quilter-1.8.4-2.20190425git5c7a1ca.fc30.src.rpm
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/quilter
quilter-1.8.4-2.20190425git5c7a1ca.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6c49bc1d53
quilter-1.8.4-2.20190425git5c7a1ca.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6c49bc1d53
quilter-1.8.4-2.20190425git5c7a1ca.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.