Bug 1703369 - thunderbolt not working: interrupt for TX ring 0 is already enabled
Summary: thunderbolt not working: interrupt for TX ring 0 is already enabled
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 30
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-26 09:10 UTC by Christian Kellner
Modified: 2019-06-14 12:49 UTC (History)
16 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-06-14 12:49:26 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Christian Kellner 2019-04-26 09:10:37 UTC
This is 5.0.9-301.fc30.x86_64 from F30/updates-testing. Thunderbolt stopped working. No devices exposed in /sys/bus/thunderbolt. This is a Dell XPS 13  9370 (I think this is an AplineRidge Thunderbolt chip).

[   13.553853] thunderbolt 0000:05:00.0: unexpected hop count: 1023
[   13.553858] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[   13.554348] ------------[ cut here ]------------
[   13.554349] thunderbolt 0000:05:00.0: interrupt for TX ring 0 is already enabled
[   13.554371] WARNING: CPU: 2 PID: 1022 at drivers/thunderbolt/nhi.c:104 ring_interrupt_active+0x1ee/0x240 [thunderbolt]
[   13.554371] Modules linked in: intel_uncore(+) thunderbolt(+) videobuf2_common(+) cfg80211(+) intel_rapl_perf videodev media ecdh_generic rtsx_pci_ms memstick snd_timer snd mei_me idma64 soundcore rfkill mei i2c_i801(+) intel_xhci_usb_role_switch processor_thermal_device roles intel_soc_dts_iosf intel_lpss_pci(+) intel_lpss ucsi_acpi typec_ucsi intel_pch_thermal typec int3403_thermal intel_hid int340x_thermal_zone int3400_thermal acpi_thermal_rel sparse_keymap acpi_pad pcc_cpufreq xfs libcrc32c dm_crypt i915 kvmgt mdev vfio kvm rtsx_pci_sdmmc mmc_core irqbypass i2c_algo_bit drm_kms_helper nvme crct10dif_pclmul crc32_pclmul crc32c_intel nvme_core drm serio_raw ghash_clmulni_intel rtsx_pci wmi i2c_hid pinctrl_sunrisepoint video pinctrl_intel fuse
[   13.554387] CPU: 2 PID: 1022 Comm: systemd-udevd Not tainted 5.0.9-301.fc30.x86_64 #1
[   13.554387] Hardware name: Dell Inc. XPS 13 9370/0173S1, BIOS 1.8.1 02/14/2019
[   13.554392] RIP: 0010:ring_interrupt_active+0x1ee/0x240 [thunderbolt]
[   13.554394] Code: 00 00 00 44 89 44 24 04 e8 1f 0f c0 e6 44 8b 44 24 04 4d 89 f1 4c 89 e1 48 89 c6 4c 89 fa 48 c7 c7 c0 ec a3 c0 e8 d1 09 6b e6 <0f> 0b e9 1b ff ff ff 0f b6 43 78 d3 e0 09 c7 e9 dc fe ff ff 44 03
[   13.554395] RSP: 0018:ffffb6b8c236ba38 EFLAGS: 00010082
[   13.554396] RAX: 0000000000000000 RBX: ffff93c1117ad480 RCX: ffff93c11e2968c0
[   13.554396] RDX: 0000000000000007 RSI: 0000000000000006 RDI: ffff93c11e2968c0
[   13.554397] RBP: 00000000ffffffff R08: 0000000000000001 R09: 0000000000000437
[   13.554397] R10: 000000000001886c R11: 0000000000000003 R12: ffffffffc0a3e321
[   13.554398] R13: 0000000000038200 R14: ffffffffc0a3e310 R15: ffff93c11b599f30
[   13.554399] FS:  00007fc74e6c5940(0000) GS:ffff93c11e280000(0000) knlGS:0000000000000000
[   13.554400] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   13.554401] CR2: 00007fc74f7ba8dd CR3: 0000000498086001 CR4: 00000000003606e0
[   13.554401] Call Trace:
[   13.554408]  tb_ring_start+0xbf/0x190 [thunderbolt]
[   13.554414]  tb_ctl_start+0x25/0xa0 [thunderbolt]
[   13.554420]  tb_domain_add+0x59/0x140 [thunderbolt]
[   13.554425]  nhi_probe+0x2b9/0x390 [thunderbolt]
[   13.554430]  local_pci_probe+0x45/0xa0
[   13.554433]  pci_device_probe+0x118/0x1a0
[   13.554436]  really_probe+0xf9/0x3a0
[   13.554438]  driver_probe_device+0xb6/0x100
[   13.554440]  __driver_attach+0xe1/0x110
[   13.554441]  ? driver_probe_device+0x100/0x100
[   13.554443]  bus_for_each_dev+0x7a/0xc0
[   13.554445]  ? klist_add_tail+0x3b/0x60
[   13.554447]  bus_add_driver+0x16a/0x220
[   13.554448]  driver_register+0x6c/0xb0
[   13.554450]  ? 0xffffffffc0a52000
[   13.554455]  nhi_init+0x2d/0x1000 [thunderbolt]
[   13.554458]  do_one_initcall+0x46/0x1c4
[   13.554460]  ? free_unref_page_commit+0x95/0x110
[   13.554462]  ? _cond_resched+0x15/0x30
[   13.554464]  ? kmem_cache_alloc_trace+0x157/0x1c0
[   13.554466]  ? do_init_module+0x23/0x210
[   13.554468]  do_init_module+0x5c/0x210
[   13.554470]  load_module+0x23e3/0x2910
[   13.554473]  ? __do_sys_init_module+0x160/0x190
[   13.554475]  __do_sys_init_module+0x160/0x190
[   13.554477]  do_syscall_64+0x5b/0x150
[   13.554479]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[   13.554481] RIP: 0033:0x7fc74f6c5a6e
[   13.554482] Code: 48 8b 0d 1d 44 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 49 89 ca b8 af 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d ea 43 0c 00 f7 d8 64 89 01 48
[   13.554483] RSP: 002b:00007ffc2e417e58 EFLAGS: 00000246 ORIG_RAX: 00000000000000af
[   13.554484] RAX: ffffffffffffffda RBX: 000055f6078387a0 RCX: 00007fc74f6c5a6e
[   13.554484] RDX: 00007fc74f31a84d RSI: 00000000000496b6 RDI: 000055f608134fd0
[   13.554485] RBP: 000055f608134fd0 R08: 000055f6077e6580 R09: 0000000000000006
[   13.554486] R10: 0000000000000007 R11: 0000000000000246 R12: 00007fc74f31a84d
[   13.554486] R13: 0000000000000001 R14: 000055f6077fcbd0 R15: 000055f607931be0
[   13.554487] ---[ end trace d563e90f6bbb5f47 ]---
[   13.554499] ------------[ cut here ]------------
[   13.554500] thunderbolt 0000:05:00.0: interrupt for RX ring 0 is already enabled
[   13.554517] WARNING: CPU: 2 PID: 1022 at drivers/thunderbolt/nhi.c:104 ring_interrupt_active+0x1ee/0x240 [thunderbolt]
[   13.554517] Modules linked in: intel_uncore(+) thunderbolt(+) videobuf2_common(+) cfg80211(+) intel_rapl_perf videodev media ecdh_generic rtsx_pci_ms memstick snd_timer snd mei_me idma64 soundcore rfkill mei i2c_i801(+) intel_xhci_usb_role_switch processor_thermal_device roles intel_soc_dts_iosf intel_lpss_pci(+) intel_lpss ucsi_acpi typec_ucsi intel_pch_thermal typec int3403_thermal intel_hid int340x_thermal_zone int3400_thermal acpi_thermal_rel sparse_keymap acpi_pad pcc_cpufreq xfs libcrc32c dm_crypt i915 kvmgt mdev vfio kvm rtsx_pci_sdmmc mmc_core irqbypass i2c_algo_bit drm_kms_helper nvme crct10dif_pclmul crc32_pclmul crc32c_intel nvme_core drm serio_raw ghash_clmulni_intel rtsx_pci wmi i2c_hid pinctrl_sunrisepoint video pinctrl_intel fuse
[   13.554530] CPU: 2 PID: 1022 Comm: systemd-udevd Tainted: G        W         5.0.9-301.fc30.x86_64 #1
[   13.554530] Hardware name: Dell Inc. XPS 13 9370/0173S1, BIOS 1.8.1 02/14/2019
[   13.554535] RIP: 0010:ring_interrupt_active+0x1ee/0x240 [thunderbolt]
[   13.554536] Code: 00 00 00 44 89 44 24 04 e8 1f 0f c0 e6 44 8b 44 24 04 4d 89 f1 4c 89 e1 48 89 c6 4c 89 fa 48 c7 c7 c0 ec a3 c0 e8 d1 09 6b e6 <0f> 0b e9 1b ff ff ff 0f b6 43 78 d3 e0 09 c7 e9 dc fe ff ff 44 03
[   13.554537] RSP: 0018:ffffb6b8c236ba38 EFLAGS: 00010082
[   13.554538] RAX: 0000000000000000 RBX: ffff93c1117ad300 RCX: ffff93c11e2968c0
[   13.554538] RDX: 0000000000000007 RSI: 0000000000000006 RDI: ffff93c11e2968c0
[   13.554539] RBP: 00000000ffffffff R08: 0000000000000001 R09: 000000000000046d
[   13.554540] R10: 0000000000019970 R11: 0000000000000003 R12: ffffffffc0a3e329
[   13.554540] R13: 000000000003827c R14: ffffffffc0a3e310 R15: ffff93c11b599f30
[   13.554541] FS:  00007fc74e6c5940(0000) GS:ffff93c11e280000(0000) knlGS:0000000000000000
[   13.554542] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   13.554543] CR2: 00007fc74f7ba8dd CR3: 0000000498086001 CR4: 00000000003606e0
[   13.554543] Call Trace:
[   13.554549]  tb_ring_start+0xbf/0x190 [thunderbolt]
[   13.554554]  tb_ctl_start+0x2f/0xa0 [thunderbolt]
[   13.554555] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
[   13.554561]  tb_domain_add+0x59/0x140 [thunderbolt]
[   13.554566]  nhi_probe+0x2b9/0x390 [thunderbolt]
[   13.554567]  local_pci_probe+0x45/0xa0
[   13.554569]  pci_device_probe+0x118/0x1a0
[   13.554571]  really_probe+0xf9/0x3a0
[   13.554573]  driver_probe_device+0xb6/0x100
[   13.554575]  __driver_attach+0xe1/0x110
[   13.554576]  ? driver_probe_device+0x100/0x100
[   13.554577]  bus_for_each_dev+0x7a/0xc0
[   13.554578]  ? klist_add_tail+0x3b/0x60
[   13.554580]  bus_add_driver+0x16a/0x220
[   13.554581]  driver_register+0x6c/0xb0
[   13.554582]  ? 0xffffffffc0a52000
[   13.554587]  nhi_init+0x2d/0x1000 [thunderbolt]
[   13.554589]  do_one_initcall+0x46/0x1c4
[   13.554590]  ? free_unref_page_commit+0x95/0x110
[   13.554591]  ? _cond_resched+0x15/0x30
[   13.554593]  ? kmem_cache_alloc_trace+0x157/0x1c0
[   13.554594]  ? do_init_module+0x23/0x210
[   13.554595]  do_init_module+0x5c/0x210
[   13.554597]  load_module+0x23e3/0x2910
[   13.554600]  ? __do_sys_init_module+0x160/0x190
[   13.554601]  __do_sys_init_module+0x160/0x190
[   13.554603]  do_syscall_64+0x5b/0x150
[   13.554605]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[   13.554606] RIP: 0033:0x7fc74f6c5a6e
[   13.554607] Code: 48 8b 0d 1d 44 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 49 89 ca b8 af 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d ea 43 0c 00 f7 d8 64 89 01 48
[   13.554608] RSP: 002b:00007ffc2e417e58 EFLAGS: 00000246 ORIG_RAX: 00000000000000af
[   13.554609] RAX: ffffffffffffffda RBX: 000055f6078387a0 RCX: 00007fc74f6c5a6e
[   13.554609] RDX: 00007fc74f31a84d RSI: 00000000000496b6 RDI: 000055f608134fd0
[   13.554610] RBP: 000055f608134fd0 R08: 000055f6077e6580 R09: 0000000000000006
[   13.554611] R10: 0000000000000007 R11: 0000000000000246 R12: 00007fc74f31a84d
[   13.554611] R13: 0000000000000001 R14: 000055f6077fcbd0 R15: 000055f607931be0
[   13.554612] ---[ end trace d563e90f6bbb5f48 ]---
[   13.554623] thunderbolt 0000:05:00.0: ICM firmware is in wrong mode: 15

Comment 1 Christian Kellner 2019-04-26 09:16:08 UTC
Works on 5.0.7-300.fc30.x86_64

Comment 2 Christian Kellner 2019-05-09 09:14:33 UTC
Apparently an upstream regression, see https://lore.kernel.org/lkml/s5hy33siofw.wl-tiwai@suse.de/T/#u

Comment 3 Christian Kellner 2019-05-09 09:24:37 UTC
The bad commit c8b1917c8987 ("ACPICA: Clear status of GPEs before enabling them") was reverted upstream as well as in the 5.0.x stable series, see here: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.0.14&id=742c556944e1ff299e3a2e305145c16876b0ed96 So should be in 5.0.12 if I am not mistaken.

Comment 4 Christian Kellner 2019-05-13 11:36:25 UTC
Can confirm that this is fixed in mainline 5.0.14.


Note You need to log in before you can comment on or make changes to this bug.