Bug 1703403

+++ This bug was initially created as a clone of Bug #1651115 +++

Can reproduce the bug with virt-v2v-1.38.4-5.module+el8+2173+537e5cb5.x86_64, so clone the bug from rhel7

+++ This bug was initially created as a clone of Bug #1605242 +++

Description of problem:
Update nbdkit info for vddk in v2v man page

Version-Release number of selected component (if applicable):
virt-v2v-1.38.2-8.el7.x86_64
libguestfs-1.38.2-8.el7.x86_64


How reproducible:
100%

Steps to Reproduce:
1.Check nbdkit info of vddk in v2v man page, it said you must compile nbdkit to enable the VDDK plugin

#man virt-v2v
....
INPUT FROM VDDK
       Virt-v2v is able to import guests using VMware’s proprietary VDDK
       library (a.k.a. VixDiskLib).

   VDDK: PREREQUISITES
....
       2.  You must also compile nbdkit, enabling the VDDK plugin.  nbdkit ≥
           1.1.25 is recommended, but it is usually best to compile from the
           git tree.

           ·   https://github.com/libguestfs/nbdkit

           ·   https://github.com/libguestfs/nbdkit/tree/master/plugins/vddk

           Compile nbdkit as described in the sources (see link above).

           You do not need to run "make install" because you can run nbdkit
           from its source directory.  The source directory has a shell script
           called nbdkit which runs the locally built copy of nbdkit and its
           plugins.  So set $PATH to point to the nbdkit top build directory
           (that is, the directory containing the shell script called nbdkit),
           eg:

            export PATH=/path/to/nbdkit-1.1.x:$PATH

    .....

Actual results:
Should update nbdkit info for vddk in downstream v2v man page because customers should use nbdkit-plugin-vddk rpm package directly rather than self-compiled 

Expected results:
Update nbdkit info for vddk in v2v man page


Additional info:

--- Additional comment from Pino Toscano on 2018-07-23 11:50:02 EDT ---

(In reply to mxie from comment #0)
> Actual results:
> Should update nbdkit info for vddk in downstream v2v man page because
> customers should use nbdkit-plugin-vddk rpm package directly rather than
> self-compiled 

There is no nbdkit-plugin-vddk RPM, and it cannot exist.

--- Additional comment from Tomáš Golembiovský on 2018-07-23 16:58:33 EDT ---

(In reply to Pino Toscano from comment #2)
> (In reply to mxie from comment #0)
> > Actual results:
> > Should update nbdkit info for vddk in downstream v2v man page because
> > customers should use nbdkit-plugin-vddk rpm package directly rather than
> > self-compiled 
> 
> There is no nbdkit-plugin-vddk RPM, and it cannot exist.

I believe he's talking about the self-build RPM from the spec file that exists.

Also, it is not necessary to build your own nbdkit as it will be available in RHEL 7.6.

--- Additional comment from Richard W.M. Jones on 2018-09-11 05:15:48 EDT ---

This still needs to be done, but we've missed 7.6 at this point,
so moving to 7.7.

--- Additional comment from Richard W.M. Jones on 2018-11-19 10:07:49 CET ---

I didn't set Internal Target on this because I don't know when we
want to deliver this fix.  It's not very important so could be
pushed back easily to 8.1.

--- Additional comment from mxie on 2018-11-19 10:10:55 CET ---

Found another mistake in virt-v2v man page for VDDK,I think should correct " nbdkit-vddk-plugin" as nbdkit-plugin-vddk"

#man virt-v2v
....
 -io vddk-vimapiver=APIVER
           When using VDDK mode, these options are passed unmodified to the
           nbdkit(1) VDDK plugin.  Please refer to nbdkit-vddk-plugin(1).
           These are all optional.
....
  3.  You must find the SSL "thumbprint" of your VMware server.  How to
           do this is explained in nbdkit-vddk-plugin(1), also available at
           the link above.
...

--- Additional comment from Pino Toscano on 2018-11-19 10:32:28 CET ---

(In reply to Richard W.M. Jones from comment #1)
> I didn't set Internal Target on this because I don't know when we
> want to deliver this fix.  It's not very important so could be
> pushed back easily to 8.1.

It's a small documentation fix, and this kind of changes is generally accepted in testing phase (even on RHEL 7).

Once fixed upstream, I will backport it to 8.0.0, in case we are not in blockers/exceptions phase.

--- Additional comment from Pino Toscano on 2018-11-19 13:59:15 CET ---

(In reply to mxie from comment #2)
> Found another mistake in virt-v2v man page for VDDK,I think should correct "
> nbdkit-vddk-plugin" as nbdkit-plugin-vddk"
> 
> #man virt-v2v
> ....
>  -io vddk-vimapiver=APIVER
>            When using VDDK mode, these options are passed unmodified to the
>            nbdkit(1) VDDK plugin.  Please refer to nbdkit-vddk-plugin(1).
>            These are all optional.
> ....
>   3.  You must find the SSL "thumbprint" of your VMware server.  How to
>            do this is explained in nbdkit-vddk-plugin(1), also available at
>            the link above.
> ...

The package nbdkit-plugin-vddk installs a man page called nbdkit-vddk-plugin, so the references are correct.

--- Additional comment from Pino Toscano on 2019-04-12 16:23:48 CEST ---

Simple patch posted upstream:
https://www.redhat.com/archives/libguestfs/2019-April/msg00102.html

--- Additional comment from Pino Toscano on 2019-04-12 16:52:49 CEST ---

Fixed upstream with
https://github.com/libguestfs/libguestfs/commit/0704d8eb0bcc8139886eb4291f75a3ca49a91e58
which is in libguestfs >= 1.41.1.