Reproducer: echo 'int main(void) {}' > u.c gcc `rpm --eval "%build_cflags %build_ldflags" | sed s/-Wp,-D_FORTIFY_SOURCE=2//` u.c annocheck -v a.out Actual output: Hardened: a.out: MAYB: (component: main): -D_FORTIFY_SOURCE setting not recorded. Hardened: a.out: MAYB: (component: main): -D_FORTIFY_SOURCE setting not recorded. […] Expected output: I think this should be a failure because we know that there is annobin-covered code which does not use the right _FORTIFY_SOURCE setting.
Hi Florian, I had originally coded it that way because I was seeing a lot of false positives for missing -D_FORTIFY_SOURCE definitions. I have now updated the test so that if -D_FORTIFY_SOURCE is not seen but -D_GLIBCXX_ASSERTIONS is seen, then the check has failed. (And similarly for the glibcxx_assertion test). The theory being that if we have seen at least one pre-processor definition then we should have seen both, but if we have seen neither then we might be dealing with a situation where pre-processing been applied ahead of time, and hence not used on the command line recorded by annobin. Cheers Nick Fixed in: annobin-8.76-1.fc31
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'.
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31.
This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.