Bug 1703757 - Open Link in New Tab always redirects user to project list page
Summary: Open Link in New Tab always redirects user to project list page
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: 4.5.0
Assignee: Robb Hamilton
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-28 07:13 UTC by Yadan Pei
Modified: 2020-07-13 17:11 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Select links in the masthead have an href value of "#" with an onClick handler containing the target destination. Consequence: As a result, those links have the option to open in a new tab, but utilizing that option opens /#, which resolves to the dashboard instead of the intended target destination. Fix: Any links with an href of "#" are updated to a button element so the "Open Link in New Tab" option is not available. Result: Links that have the "Open Link in New Tab" option show the correct URL.
Clone Of:
Environment:
Last Closed: 2020-07-13 17:11:03 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 5253 0 None closed Bug 1703757: Fix bug where some masthead actions cannot open in new tab 2020-07-07 17:47:21 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:11:16 UTC

Description Yadan Pei 2019-04-28 07:13:00 UTC
Description of problem:
When user try to open some links on admin console by "Open Link in New Tab" , it always directs to project list page

Version-Release number of selected component (if applicable):
Cluster version:4.1.0-0.nightly-2019-04-25-121505
console commit: io.openshift.build.commit.url=https://github.com/openshift/console/commit/6ffcf1e550f72523d69ec04e2d4b45b8c0e682a0

How reproducible:
Always

Steps to Reproduce:
1. Login to cluster console, open Documentation link via ? -> Documentation
2. Right click on Documentation and click 'Open Link in New Tab'
3. Right click on 'Multi-Cluster Manager' and click 'Open Link in New Tab'

Actual results:
2. It directs user to project list page on https://<console_route>/k8s/cluster/projects
3. It redirects to project list page on https://<console_route>/k8s/cluster/projects

Expected results:
2. It should open documentation link https://docs.openshift.com/container-platform/4.1/welcome/index.html
3. It should open https://cloud.openshift.com/clusters

Additional info:
All buttons links to a page have the same issue

Comment 1 Samuel Padgett 2019-04-28 14:16:10 UTC
This is a limitation of the Patternfly 4 dropdown we're using in the masthead. This can't be fixed in console without upstream Patternfly changes.

Moving to low since the links already open in a new window. I agree this is something we should try to fix, however. Even making this a `button` element fixes the problem because the open in new tab would no longer appear, but it's better if we can make this a true `a` element with an `href`.

Comment 2 Robb Hamilton 2020-01-13 20:38:35 UTC
The "Documentation" and "Multi-Cluster Manager" are fixed in 4.2.0+, but "Command Line Tools" is not.

Comment 5 Yadan Pei 2020-05-07 08:52:52 UTC
1. Click on app launcher icon, right click on 'OpenShift Cluster Manager' -> Open Link in new tab, it will goes to https://cloud.redhat.com/openshift/....
2. Click on ? -> right click on 'Documentation' -> Open Link in new tab, it goes to https://docs.openshift.com/container-platform/4.5/
3. Click on ? -> right click on 'Command Line Tools' -> Open Link in new tab, it goes to /command-line-tools page


Verified on     4.5.0-0.nightly-2020-05-06-003431

Comment 7 errata-xmlrpc 2020-07-13 17:11:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.