Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1703840

Summary:	drop vdsm-hook-macspoof
Product:	[oVirt] vdsm	Reporter:	Dan Kenigsberg <danken>
Component:	Packaging.rpm	Assignee:	Dan Kenigsberg <danken>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Michael Burman <mburman>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.40.0	CC:	bilias, bugs, dholler, emarcus, mkalinin
Target Milestone:	ovirt-4.4.0	Flags:	mperina: ovirt-4.4?
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Removed functionality
Doc Text:	The vdsm-hook-macspoof has been dropped from the VDSM code. If you still require the ifacemacspoof hook, you can find and fix the vnic profiles using a script similar to the one provided in the https://gerrit.ovirt.org/#/c/94613/ commit message.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-20 20:01:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Kenigsberg 2019-04-28 18:25:30 UTC

vdsm-hook-macspoof was created to let VM owners override the vdsm-no-mac-spoofing  that was once hard-coded on each vNIC.

Since ovirt-4.0's
Bug 1317441 - [RFE] Allow MAC Anti-Spoofing per interface instead of globally
the hook is no longer needed, because ovirt-engine supports selection of filters, including the "Empty" one.

Thus, we can finally drop vdsm-hook-macspoof from vdsm code.

Comment 1 Dominik Holler 2019-06-21 14:25:40 UTC

Can the state of the bug change to MODIFIED ?

Comment 2 Dan Kenigsberg 2019-06-21 14:46:09 UTC

It can and it should.

Comment 3 Michael Burman 2019-10-23 06:54:44 UTC

Verified with vdsm-4.40.0-127.gitc628cce.el8ev.x86_64

Comment 4 Sandro Bonazzola 2020-05-20 20:01:20 UTC

This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 5 Kapetanakis Giannis 2021-09-02 08:35:45 UTC

This means that vdsm-no-mac-spoofing is NO longer forced on each vNIC?
Thus if someone wants to apply mac-spoofing protection has to apply the filter manually on each vNIC? (no longer by default).

I'm in the process of upgrading 4.3 -> 4.4 and I definitely want some nics to NOT filter since it breaks carp/vrrp.

Sorry for reopening, but documentation on
https://www.ovirt.org/release/4.4.0/#vdsm-1 and
https://www.ovirt.org/documentation/administration_guide/index.html#Creating_a_VNIC_Profile

is not clear about this topic. 

best