Bug 170492 - Review Request: qucs - Circuit simulator
Review Request: qucs - Circuit simulator
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Aurelien Bompard
Fedora Package Reviews List
http://qucs.sourceforge.net/
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2005-10-12 06:33 EDT by Eric Tanguy
Modified: 2007-11-30 17:11 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-10-21 18:21:49 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
Proposed spec changes to make package RPM_OPT_FLAGS aware (1.01 KB, patch)
2005-10-18 03:41 EDT, Ralf Corsepius
no flags Details | Diff
Hacks to make configure script RPM_OPT_FLAGS aware (657 bytes, patch)
2005-10-18 03:44 EDT, Ralf Corsepius
no flags Details | Diff

  None (edit)
Description Eric Tanguy 2005-10-12 06:33:35 EDT
Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/qucs.spec
SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/qucs-0.0.7-5.src.rpm
Description: Qucs is a circuit simulator with graphical user interface.  The
software aims to support all kinds of circuit simulation types,
e.g. DC, AC, S-parameter and harmonic balance analysis.

This is my first package and i'm seeking a sponsor.
Thanks
Comment 1 Alain Portal 2005-10-12 07:35:21 EDT
Sorry, I can't sponsor you. 
 
Some improvements: 
Put the full download url in Source0, i.e. 
Source0 http://dl.sf.net/qucs/%{name}-%{version}.tar.gz 
 
In %changelog, remove ".fc4" in "0.0.7-5.fc4" to make rpmlint happy 
 
Build fine in mock 
Comment 2 Alain Portal 2005-10-12 07:52:54 EDT
In %install section, add rm -rf $RPM_BUILD_ROOT before make install 
 
Suggestion for the desktop file: 
desktop-file-install --vendor fedora \ 
  --dir $RPM_BUILD_ROOT%{_datadir}/applications \ 
  --add-category "Engineering" \ 
  --add-category "Electronics" \ 
  --add-category "X-Fedora" \ 
  %{SOURCE1} 
 
I think you should remove the "Categories" line in the desktop file, this 
isn't a Gnome based application. 
 
Comment 3 Eric Tanguy 2005-10-12 13:09:29 EDT
Comment #1 : Ok it will be done quickly
Comment #2 : your suggestion about desktop file doesn't seem to work 
+ desktop-file-install --vendor fedora --dir
/var/tmp/qucs-0.0.7-5-root-tanguy/usr/share/applications --add-category
Engineering ' '
Error on file " ": Failed to open file ' ': No such file or directory
erreur: Mauvais status de sortie pour /var/tmp/rpm-tmp.25083 (%install)
Comment 4 Alain Portal 2005-10-13 06:29:42 EDT
Work for me. 
I suspect you copy/paste from the bugzilla html page. 
Don't do this but edit by hand. I often meet problems about caracters set or 
related when I copy/paste examples of C source code or shell script. 
Comment 5 Eric Tanguy 2005-10-13 12:26:39 EDT
Ok you're right. Thanks. Now all it's ok and the files are uploaded. I still
need a complete review and a sponsor.
Comment 6 Aurelien Bompard 2005-10-15 04:32:54 EDT
I'll do the sponsoring, but first, there is a couple of improvements to do :

* Desktop file: the Categories tag should contain "Application" (wiki:
PackagingGuidelines#desktop)
Since your desktop file is in a separate source, you could just add this line to
it :
Categories=Application;Electronics;Engineering;
and only use "--add-category X-Fedora" with desktop-file-install in the spec
file (since this category is Fedora-specific, I would leave it in the spec file,
but you can add it to the desktop file too)

Minor :
 * use %setup -q in %prep, to cut off the untarring output.
Comment 7 Eric Tanguy 2005-10-15 05:13:52 EDT
I did the improvements asked and uploaded the files. Do i need to increase the
release number in spec file ?
Comment 8 Aurelien Bompard 2005-10-15 08:51:23 EDT
Increasing the release tag makes it easier to know which version has been
approved, so please do that next time.

Review for release 5:
* RPM name is OK
* Source qucs-0.0.7.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of qucs looks OK
* File list of qucs looks OK
* Works fine
APPROVED

Follow the steps to become an official contributor
(http://fedoraproject.org/wiki/Extras/Contributors) and I'll sponsor you.

Comment 9 Ralf Corsepius 2005-10-18 01:24:41 EDT
VETO

Package does not acknowledge RPM_OPT_FLAGS

Pushing package back to FE-REVIEW.
Comment 10 Ralf Corsepius 2005-10-18 03:41:39 EDT
Created attachment 120112 [details]
Proposed spec changes to make package RPM_OPT_FLAGS aware
Comment 11 Ralf Corsepius 2005-10-18 03:44:33 EDT
Created attachment 120113 [details]
Hacks to make configure script RPM_OPT_FLAGS aware

The origin of this problem is a broken configure script.
This patch is supposed to fix bring this configure script into usable shape.
Comment 12 Eric Tanguy 2005-10-19 06:34:47 EDT
Thanks for the patches. I also contact the developer and he put a patch in the
cvs version. It will be all right on the next release.
Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/qucs.spec
SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/qucs-0.0.7-6.src.rpm
I don't know if the new package have to be approved one more time ?
Comment 13 Eric Tanguy 2005-10-19 11:28:57 EDT
New patched version for x86_64 arch
Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/qucs.spec
SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/qucs-0.0.7-7.src.rpm
Comment 14 Aurelien Bompard 2005-10-21 18:21:49 EDT
Looks OK, approving and closing bug (release 7 is already on the servers)
Comment 15 Christian Iseli 2007-01-02 19:43:35 EST
Changed summary for tracking purposes.

Note You need to log in before you can comment on or make changes to this bug.