Description of problem: Due to my own https://gerrit.ovirt.org/#/c/91979/, if a DC has no hosts in Up state, ovirt-log-collector will print an error message on the screen due to the dump_chains dictionary not containing the key with the data center name. Just the collection thread for the host raises the exception, log collection seems to work regardless. But the error on the screen is not nice. Version-Release number of selected component (if applicable): ovirt-log-collector-4.3.2-1.el7.noarch How reproducible: 100% Steps to Reproduce: 1. Create DC 2. Add a host to DC, keep it in maintenance Actual results: About to collect information from 3 hypervisors. Continue? (Y/n): INFO: Data center 'Default' volume chains to be collected by 'host1.rhvlab' INFO: Gathering information from selected hypervisors... INFO: collecting information from host3.rhvlab INFO: collecting information from host1.rhvlab ERROR: 'EmptyDC' Use the -h option to see usage.
I have the patch ready, just let me run some more tests with empty DCs/Clusters and things in down state to ensure there are no other problems with this. Will send it to gerrit soon.
Patch up for review, but I want to run more tests.
I ran same more tests and it looks fine. Douglas, could you please help with the reviews and 4.3.z this? I'm going on leave in a few hours.
Douglas, anything missing for closing this bug? all referenced patches are merged.
Logs collected with no error on DC with no UP host. verified in ovirt-log-collector-4.3.3-1.el7ev.noarch
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2019:2443