Bug 1705402 - Review Request: perl-HTML-HTML5-Sanity - Make HTML5 DOM trees less insane
Summary: Review Request: perl-HTML-HTML5-Sanity - Make HTML5 DOM trees less insane
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1705390
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-02 08:52 UTC by Petr Pisar
Modified: 2019-05-03 13:44 UTC (History)
2 users (show)

Fixed In Version: perl-HTML-HTML5-Sanity-0.105-1.fc31
Clone Of:
Environment:
Last Closed: 2019-05-03 13:44:13 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-05-02 08:52:14 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-HTML-HTML5-Sanity/perl-HTML-HTML5-Sanity.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-HTML-HTML5-Sanity/perl-HTML-HTML5-Sanity-0.105-1.fc31.src.rpm
Description:
The Document Object Model (DOM) generated by HTML::HTML5::Parser meets the
requirements of the HTML5 specification, but will probably catch a lot of
people by surprise. This Perl module returns the DOM with corrected xml:lang
attributes.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-05-03 06:51:41 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-HTML-HTML5-Sanity-0.105-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Exporter)
      1 perl(Locale::Country)
      1 perl(:MODULE_COMPAT_5.28.2)
      1 perl(strict)
      1 perl(:VERSION) >= 5.10.0
      1 perl(warnings)
      1 perl(XML::LibXML) >= 1.70
Binary requires are Ok.

$ rpm -qp --provides perl-HTML-HTML5-Sanity-0.105-1.fc31.noarch.rpm | sort | uniq -c
      1 perl(HTML::HTML5::Sanity) = 0.105
      1 perl-HTML-HTML5-Sanity = 0.105-1.fc31
Binary provides are Ok.

$ rpmlint ./perl-HTML-HTML5-Sanity*
perl-HTML-HTML5-Sanity.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml
perl-HTML-HTML5-Sanity.noarch: W: spelling-error %description -l en_US lang -> Lang, lag, slang
perl-HTML-HTML5-Sanity.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml
perl-HTML-HTML5-Sanity.src: W: spelling-error %description -l en_US lang -> Lang, lag, slang
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok

Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.

Resolution:
Approved

Comment 2 Gwyn Ciesla 2019-05-03 13:33:47 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-HTML-HTML5-Sanity

Comment 3 Petr Pisar 2019-05-03 13:44:13 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.