Red Hat Bugzilla – Bug 170616
Review Request: ipxripd - IPX RIP/SAP daemon - routing for IPX networks
Last modified: 2011-12-06 01:12:03 EST
Yes, IPX looks like an obsolete thing.
Many distros ago RedHat began to plan IPX removal from its main distribution, however it till now there. It means that IPX is still necessary for users.
This package provides IPX routing and helps IPX browsing. Such functionality is missed in the standard ncpfs package.
Spec Url: http://dmitry.butskoy.name/ipxripd/ipxripd.spec
SRPM Url: http://dmitry.butskoy.name/ipxripd/ipxripd-0.8-1.src.rpm
ipxripd is an implementation of Novell's RIP and SAP protocols.
It automagically builds and updates IPX routing table in the Linux kernel.
ipxripd can be useful to get a Linux box to act as an IPX router.
- rpmlint only says:
W: ipxripd incoherent-init-script-name ipxd
Looks like an OK name for the script though.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- init script
However, %defattr(-,root,root) should be %defattr(-,root,root,-)
(I had to modprobe ipx before ipxd would stay running and not immediately exit.)
Make the %defattr change and this is APPROVED
> I had to modprobe ipx before ipxd would stay running and not immediately exit.
Normally ipxd is run after the IPX is configured by init scripts (therefore ipx
module is already loaded, ipx interfaces are activated etc.).
> %defattr(-,root,root) should be %defattr(-,root,root,-)
Thanks for review!