Spec URL: https://atim.fedorapeople.org/for-review/gnome-shell-theme-flat-remix.spec SRPM URL: https://atim.fedorapeople.org/for-review/gnome-shell-theme-flat-remix-0.0.20190428-1.fc30.src.rpm Description: Flat Remix GNOME theme is a pretty simple shell theme inspired on material design following a modern design using "flat" colors with high contrasts and sharp borders. Themes: • Flat Remix • Flat Remix Dark • Flat Remix Darkest • Flat Remix Miami • Flat Remix Miami Dark Variants: • Full Panel: No topbar spacing Fedora Account System Username: atim Working COPR: https://copr.fedorainfracloud.org/coprs/atim/flat-remix-theme
This is an unofficial review as I'm not official Fedora packager. See Issues below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files - Not sure why rpmlint warns about this, the URL works in the browser: gnome-shell-theme-flat-remix.noarch: W: invalid-url URL: https://drasite.com/flat-remix-gnome <urlopen error [Errno -2] Name or service not known> ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Creative Commons Attribution- ShareAlike Public License (v4.0)", "*No copyright* Creative Commons Attribution-ShareAlike Public License (v4.0)". 644 files have unknown license. Detailed output of licensecheck in reviews/gnome-shell-theme-flat-remix /review-gnome-shell-theme-flat-remix/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gnome-shell/modes, /usr/share/gnome-shell/theme [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gnome-shell/modes, /usr/share/gnome-shell/theme [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gnome-shell-theme-flat-remix-0.0.20190428-1.fc31.noarch.rpm gnome-shell-theme-flat-remix-0.0.20190428-1.fc31.src.rpm gnome-shell-theme-flat-remix.noarch: W: spelling-error %description -l en_US topbar -> top bar, top-bar, toolbar gnome-shell-theme-flat-remix.src: W: spelling-error %description -l en_US topbar -> top bar, top-bar, toolbar gnome-shell-theme-flat-remix.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sh: /usr/bin/python: No such file or directory /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') gnome-shell-theme-flat-remix.noarch: W: spelling-error %description -l en_US topbar -> top bar, top-bar, toolbar gnome-shell-theme-flat-remix.noarch: W: invalid-url URL: https://drasite.com/flat-remix-gnome <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/daniruiz/flat-remix-gnome/archive/20190428.tar.gz#/gnome-shell-theme-flat-remix-0.0.20190428.tar.gz : CHECKSUM(SHA256) this package : 69b96a3c03a3bd3d23e22ced28d73817141f62d0699f286eee0e5db158d27d89 CHECKSUM(SHA256) upstream package : 69b96a3c03a3bd3d23e22ced28d73817141f62d0699f286eee0e5db158d27d89 Requires -------- gnome-shell-theme-flat-remix (rpmlib, GLIBC filtered): gnome-shell Provides -------- gnome-shell-theme-flat-remix: gnome-shell-theme-flat-remix Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -n gnome-shell-theme-flat-remix Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Haskell, R, Java, C/C++, Ocaml, PHP, SugarActivity, Perl, Python, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
- Bump to latest release - You should own these dirs: [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gnome-shell/modes, /usr/share/gnome-shell/theme Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Creative Commons Attribution- ShareAlike Public License (v4.0)", "*No copyright* Creative Commons Attribution-ShareAlike Public License (v4.0)". 644 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gnome-shell-theme-flat-remix/review-gnome- shell-theme-flat-remix/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gnome-shell/modes, /usr/share/gnome-shell/theme [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gnome-shell-theme-flat-remix-0.0.20190428-1.fc31.noarch.rpm gnome-shell-theme-flat-remix-0.0.20190428-1.fc31.src.rpm gnome-shell-theme-flat-remix.noarch: W: spelling-error %description -l en_US topbar -> top bar, top-bar, toolbar gnome-shell-theme-flat-remix.src: W: spelling-error %description -l en_US topbar -> top bar, top-bar, toolbar gnome-shell-theme-flat-remix.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
@Markku Korkeala, apologize i missed email. 🤷🏻♂️ > - Not sure why rpmlint warns about this, the URL works in the browser: > gnome-shell-theme-flat-remix.noarch: W: invalid-url URL: https://drasite.com/flat-remix-gnome > <urlopen error [Errno -2] Name or service not known> Fine for me, but i noticed some maintainers have this issue too when reviewing. @Robert, fixed. Spec URL: https://atim.fedorapeople.org/for-review/gnome-shell-theme-flat-remix.spec SRPM URL: https://atim.fedorapeople.org/for-review/gnome-shell-theme-flat-remix-0.0.20190530-1.fc30.src.rpm
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-theme-flat-remix
FEDORA-2019-826f325d63 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-826f325d63
FEDORA-2019-ce77cff080 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ce77cff080
gnome-shell-theme-flat-remix-0.0.20190530-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-826f325d63
gnome-shell-theme-flat-remix-0.0.20190530-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ce77cff080
gnome-shell-theme-flat-remix-0.0.20190530-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
gnome-shell-theme-flat-remix-0.0.20190530-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.