Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-smi.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-smi-0.3.4-1.fc30.src.rpm Description: PySMI is a pure-Python implementation of SNMP SMI MIB parser. This tool is designed to turn ASN.1 MIBs into various formats. As of this moment, JSON and pysnmp modules can be generated from ASN.1 MIBs. - Understands SMIv1, SMIv2 and de-facto SMI dialects - Turns MIBs into pysnmp classes and JSON documents - Maintains an index of MIB objects over many MIB modules - Automatically pulls ASN.1 MIBs from local directories, ZIP archives, HTTP and FTP servers Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=34680624 rpmlint output: $ rpmlint python3-smi-0.3.4-1.fc30.noarch.rpm python3-smi.noarch: W: spelling-error %description -l en_US pysnmp python3-smi.noarch: W: spelling-error %description -l en_US de -> DE, ed, d python3-smi.noarch: W: spelling-error %description -l en_US facto -> fact, factor, facts python3-smi.noarch: W: no-manual-page-for-binary mibcopy python3-smi.noarch: W: no-manual-page-for-binary mibdump 1 packages and 0 specfiles checked; 0 errors, 5 warnings. $ rpmlint python-smi-0.3.4-1.fc30.src.rpm python-smi.src: W: spelling-error %description -l en_US pysnmp python-smi.src: W: spelling-error %description -l en_US de -> DE, ed, d python-smi.src: W: spelling-error %description -l en_US facto -> fact, factor, facts python-smi.src:58: W: macro-in-comment %check python-smi.src:59: W: macro-in-comment %{__python3} 1 packages and 0 specfiles checked; 0 errors, 5 warnings. Fedora Account System Username: fab
Taking this package.
Nice to see a package from an experienced packager. Your package looks very well. Just one problem found, that check is commented out. I understand, why you did this, but looks like currently it works well, so please enable it and then I can approve this package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License", "*No copyright* BSD (unspecified)". 124 files have unknown license. Detailed output of licensecheck in /tmp/smi/1706980-python- smi/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 10 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-smi-0.3.4-1.fc31.noarch.rpm python-smi-0.3.4-1.fc31.src.rpm python3-smi.noarch: W: spelling-error %description -l en_US pysnmp python3-smi.noarch: W: spelling-error %description -l en_US de -> DE, ed, d python3-smi.noarch: W: spelling-error %description -l en_US facto -> fact, factor, facts python3-smi.noarch: W: no-manual-page-for-binary mibcopy python3-smi.noarch: W: no-manual-page-for-binary mibdump python-smi.src: W: spelling-error %description -l en_US pysnmp python-smi.src: W: spelling-error %description -l en_US de -> DE, ed, d python-smi.src: W: spelling-error %description -l en_US facto -> fact, factor, facts python-smi.src:55: W: macro-in-comment %check python-smi.src:56: W: macro-in-comment %{__python3} 2 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sh: /usr/bin/python: No such file or directory /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') python3-smi.noarch: W: spelling-error %description -l en_US pysnmp python3-smi.noarch: W: spelling-error %description -l en_US de -> DE, ed, d python3-smi.noarch: W: spelling-error %description -l en_US facto -> fact, factor, facts python3-smi.noarch: W: invalid-url URL: https://github.com/etingof/pysmi <urlopen error [Errno -2] Name or service not known> python3-smi.noarch: W: no-manual-page-for-binary mibcopy python3-smi.noarch: W: no-manual-page-for-binary mibdump 1 packages and 0 specfiles checked; 0 errors, 6 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pysmi/pysmi-0.3.4.tar.gz : CHECKSUM(SHA256) this package : bd15a15020aee8376cab5be264c26330824a8b8164ed0195bd402dd59e4e8f7c CHECKSUM(SHA256) upstream package : bd15a15020aee8376cab5be264c26330824a8b8164ed0195bd402dd59e4e8f7c Requires -------- python3-smi (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.7dist(ply) Provides -------- python3-smi: python3-smi python3.7dist(pysmi) python3dist(pysmi) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1706980 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: fonts, PHP, SugarActivity, Java, Haskell, Perl, C/C++, R, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review. I don't know about the ordering of the builds during mass rebuild but I guess that it will work as the "old" packages are there. In a worst case scenario I will get a FTBFS for one package that I have to build manually. * Fri May 31 2019 Fabian Affolter <mail> - 0.3.4-2 - Enable tests Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-smi.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-smi-0.3.4-2.fc30.src.rpm
OK, review approved. About dependencies. I don't think, this will fail on mass rebuild. All packages are still available on a mass rebuild, just older versions. But as you say, it's possible to fix this time. But btw, build with check was done also without a pysnmp buildreq. Do you really think this is needed?
pysnmp is mentioned in test-requirements.txt. Perhaps is a test available that check for the presence of pysnmp and if it's not there then the tests are not run. I will look into it.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-smi
It works only locally... DEBUG util.py:439: Error: DEBUG util.py:439: Problem: conflicting requests DEBUG util.py:439: - nothing provides python3.7dist(pysmi) needed by python3-pysnmp-4.4.9-2.fc30.noarch DEBUG util.py:577: Child return code was: 1
Not sure if we can work-around it without disabling the automatic dep generation.
FEDORA-2019-140fa9d72d has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-140fa9d72d
python-smi-0.3.4-3.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-140fa9d72d
(In reply to Fabian Affolter from comment #8) > Not sure if we can work-around it without disabling the automatic dep generation. OK, leaving on your decision, how to deal with check.
python-smi-0.3.4-3.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
FEDORA-2019-2d75cbdf12 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2d75cbdf12
python-smi-0.3.4-3.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2d75cbdf12
python-smi-0.3.4-3.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.