python-ntlm3-1.0.2-11 fails to build with python3.8. There are some deprecation warnings if you run it with 3.7. warnings: =============================== warnings summary =============================== ntlm3/HTTPNtlmAuthHandler.py:102 /builddir/build/BUILD/python-ntlm3-1.0.2/ntlm3/HTTPNtlmAuthHandler.py:102: DeprecationWarning: invalid escape sequence \- m = re.match('(NTLM [A-Za-z0-9+\-/=]+)', auth_header_value) test/integration/test_ntlm_auth_handler.py::Test_NTLMAuthHandler::test_if_we_send_a_cookie_it_gets_sent_to_the_server test/integration/test_ntlm_auth_handler.py::Test_NTLMAuthHandler::test_if_we_send_a_cookie_it_gets_sent_to_the_server test/integration/test_ntlm_auth_handler.py::Test_NTLMAuthHandler::test_if_we_send_a_cookie_it_gets_sent_to_the_server test/integration/test_ntlm_auth_handler.py::Test_NTLMAuthHandler::test_normal_handshake test/integration/test_ntlm_auth_handler.py::Test_NTLMAuthHandler::test_normal_handshake test/integration/test_ntlm_auth_handler.py::Test_NTLMAuthHandler::test_normal_handshake test/integration/test_ntlm_auth_handler_edge_cases.py::Test_NTLMAuthHandler_Issues::test_duplicate_authenticate_headers test/integration/test_ntlm_auth_handler_edge_cases.py::Test_NTLMAuthHandler_Issues::test_duplicate_authenticate_headers test/integration/test_ntlm_auth_handler_edge_cases.py::Test_NTLMAuthHandler_Issues::test_duplicate_authenticate_headers test/integration/test_ntlm_auth_handler_edge_cases.py::Test_NTLMAuthHandler_Issues::test_structure_presence_flag_is_checked test/integration/test_ntlm_auth_handler_edge_cases.py::Test_NTLMAuthHandler_Issues::test_structure_presence_flag_is_checked test/integration/test_ntlm_auth_handler_edge_cases.py::Test_NTLMAuthHandler_Issues::test_structure_presence_flag_is_checked /usr/lib/python3.7/site-packages/httpretty/core.py:438: PendingDeprecationWarning: isAlive() is deprecated, use is_alive() instead if t.isAlive(): test/unit/test_ntlm.py::Test_HashingPasswords::test_NT_hashed_password_v2 test/unit/test_ntlm.py::Test_HashedPasswordResponse::test_response_to_NTLM_v2 test/unit/test_ntlm.py::Test_HashedPasswordResponse::test_response_to_NTLM_v2 test/unit/test_ntlm.py::Test_HashedPasswordResponse::test_response_to_NTLM_v2 test/unit/test_ntlm.py::Test_HashedPasswordResponse::test_response_to_NTLM_v2 /usr/lib64/python3.7/hmac.py:153: DeprecationWarning: HMAC() without an explicit digestmod argument is deprecated since Python 3.4, and will be removed in 3.8 return HMAC(key, msg, digestmod) -- Docs: https://docs.pytest.org/en/latest/warnings.html
Created attachment 1564675 [details] Copr build log, built with python3.8
Note that there are also test FAILURES: + /usr/bin/python3 -m pytest test ============================= test session starts ============================== platform linux -- Python 3.8.0a3, pytest-4.4.1, py-1.8.0, pluggy-0.9.0 rootdir: /builddir/build/BUILD/python-ntlm3-1.0.2 collected 36 items test/integration/test_ntlm_auth_handler.py .. [ 5%] test/integration/test_ntlm_auth_handler_edge_cases.py ... [ 13%] test/unit/test_des.py .. [ 19%] test/unit/test_ntlm.py ..F.s.s..F. [ 50%] test/unit/test_u32.py ..s...s.......ss.. [100%] =================================== FAILURES =================================== _______________ Test_HashingPasswords.test_NT_hashed_password_v2 _______________ self = <test.unit.test_ntlm.Test_HashingPasswords testMethod=test_NT_hashed_password_v2> def test_NT_hashed_password_v2(self): # [MS-NLMP] page 76 > assert HexToByte("0c 86 8a 40 3b fd 7a 93 a3 00 1e f2 2e f0 2e 3f") == create_NT_hashed_password_v2(Password, User, Domain) test/unit/test_ntlm.py:28: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ ntlm3/ntlm.py:411: in create_NT_hashed_password_v2 return hmac.new(digest, (user.upper() + domain).encode('utf-16le')).digest() /usr/lib64/python3.8/hmac.py:146: in new return HMAC(key, msg, digestmod) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <hmac.HMAC object at 0x7fa02bb62ee0> key = b'\xa4\xf4\x9c@e\x10\xbd\xca\xb6\x82N\xe7\xc3\x0f\xd8R' msg = b'U\x00S\x00E\x00R\x00D\x00o\x00m\x00a\x00i\x00n\x00', digestmod = None def __init__(self, key, msg = None, digestmod = None): """Create a new HMAC object. key: key for the keyed hash object. msg: Initial input for the hash, if provided. digestmod: Required. A module supporting PEP 247. *OR* A hashlib constructor returning a new hash object. *OR* A hash name suitable for hashlib.new(). Note: key and msg must be a bytes or bytearray objects. """ if not isinstance(key, (bytes, bytearray)): raise TypeError("key: expected bytes or bytearray, but got %r" % type(key).__name__) if digestmod is None: > raise ValueError('`digestmod` is required.') E ValueError: `digestmod` is required. /usr/lib64/python3.8/hmac.py:49: ValueError _____________ Test_HashedPasswordResponse.test_response_to_NTLM_v2 _____________ self = <test.unit.test_ntlm.Test_HashedPasswordResponse testMethod=test_response_to_NTLM_v2> def test_response_to_NTLM_v2(self): # [MS-NLMP] page 76 > ResponseKeyLM = ResponseKeyNT = create_NT_hashed_password_v2(Password, User, Domain) test/unit/test_ntlm.py:64: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ ntlm3/ntlm.py:411: in create_NT_hashed_password_v2 return hmac.new(digest, (user.upper() + domain).encode('utf-16le')).digest() /usr/lib64/python3.8/hmac.py:146: in new return HMAC(key, msg, digestmod) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <hmac.HMAC object at 0x7fa02bb0fd30> key = b'\xa4\xf4\x9c@e\x10\xbd\xca\xb6\x82N\xe7\xc3\x0f\xd8R' msg = b'U\x00S\x00E\x00R\x00D\x00o\x00m\x00a\x00i\x00n\x00', digestmod = None def __init__(self, key, msg = None, digestmod = None): """Create a new HMAC object. key: key for the keyed hash object. msg: Initial input for the hash, if provided. digestmod: Required. A module supporting PEP 247. *OR* A hashlib constructor returning a new hash object. *OR* A hash name suitable for hashlib.new(). Note: key and msg must be a bytes or bytearray objects. """ if not isinstance(key, (bytes, bytearray)): raise TypeError("key: expected bytes or bytearray, but got %r" % type(key).__name__) if digestmod is None: > raise ValueError('`digestmod` is required.') E ValueError: `digestmod` is required. /usr/lib64/python3.8/hmac.py:49: ValueError
https://docs.python.org/3.7/library/hmac.html#hmac.new Deprecated since version 3.4, will be removed in version 3.8: MD5 as implicit default digest for digestmod is deprecated.
Please respond.
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'.
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31.
The coordinated rebuild of Python 3.8 has started in the `f32-python` side tag. If you figure out how to rebuild this package, please don't rebuild it in regular rawhide, but use the side tag instead: on branch master: $ fedpkg build --target=f32-python To wait for a build to show up in the side tag, do: $ koji wait-repo f32-python --build=<nvr> Where <nvr> is name-version-release of the source package, e.g. python-foo-1.1-2.fc32. An updated mock config is posted at: http://copr.fedorainfracloud.org/coprs/g/python/python3.8/ Note that it will take a while before the essential packages are rebuilt, so don't expect all your dependencies to be available right away. Thanks. Let us know if you need up to date info, or if you have any questions. PS this message is mass posted to all the bugs that block the PYTHON38 bug. If this is also a Fedora 31 FTBFS bug and you manage to fix it, you can do a f31 build as usual: on branch f31: $ fedpkg build
The f32-python side tag has been merged. In order to rebuild the package, do it in regular rawhide, but please wait until python3-3.8 is tagged: $ koji wait-repo f32-build --build python3-3.8.0~b3-3.fc32 If your built already started in f32-python, after it is finished, please tag it to rawhide with: $ koji tag-build f32-pending <nvr> For example: $ koji tag-build f32-pending libreoffice-6.3.0.4-3.fc32 Thanks! (This comment is mass posted to all bugzillas blocking the PYTHON38 tracking bug.)
(Python 3.8 has landed in the rawhide buildroot.)
This was rebuild with Python 3.8 and I'm closing it in bulk. In case you wanted to keep this bugzilla open because the fix is not ideal, please reopen. Thanks.
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days