Bug 1707739 - [OVN][NETWORK] Updating subnet's 'ipv6_address_mode' parameter returns 'OK' but does not update
Summary: [OVN][NETWORK] Updating subnet's 'ipv6_address_mode' parameter returns 'OK' b...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-provider-ovn
Classification: oVirt
Component: provider
Version: 1.2.22
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ovirt-4.3.4
: 1.2.22
Assignee: Miguel Duarte Barroso
QA Contact: msheena
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-08 08:45 UTC by msheena
Modified: 2019-06-11 06:24 UTC (History)
6 users (show)

Fixed In Version: ovirt-provider-ovn-1.2.22-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-11 06:24:05 UTC
oVirt Team: Network
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 99782 0 master MERGED Specify which fields are updateable for subnets. 2019-05-08 14:34:21 UTC

Description msheena 2019-05-08 08:45:41 UTC
Description of problem:
-----------------------
Given there is an existing OVN IPv6 subnet entity on the oVirt-provider-OVN.
When I attempt to update the subnet's 'ipv6_address_mode' parameter to a different value
Then the provider returns [200] 'OK' when in fact nothing changes.

Example: 
(updating the 'ipv6_address_mode' parameter from 'dhcpv6_stateful' to dhcpv6_stateless')
-------
[BEFORE UPDATE]
{
    "subnet": {
        "allocation_pools": [
            {
                "start": "def0:4141:ab53::2",
                "stop": "def0:4141:ab53:0:ffff:ffff:ffff:ffff"
            }
        ],
        "ipv6_address_mode": "dhcpv6_stateful",
        "cidr": "def0:4141:ab53::/64",
        "id": "02441ffd-4072-4877-8489-c18527c6ec79",
        "name": "moshe_ovn_ipv6_subnet",
        "enable_dhcp": true,
        "network_id": "5fb6e896-8a6d-4657-be93-847549662952",
        "tenant_id": "00000000000000000000000000000001",
        "dns_nameservers": [],
        "gateway_ip": "def0:4141:ab53::1",
        "ip_version": 6
    }
}

[UPDATE REQUEST]
PUT {{oVirt_fqdn}}:9696/v2.0/subnets/{{subnet_ID}}
body:
{
    "subnet": {
        "allocation_pools": [
            {
                "start": "def0:4141:ab53::2",
                "stop": "def0:4141:ab53:0:ffff:ffff:ffff:ffff"
            }
        ],
        "ipv6_address_mode": "dhcpv6_stateless",
        "cidr": "def0:4141:ab53::/64",
        "id": "02441ffd-4072-4877-8489-c18527c6ec79",
        "name": "moshe_ovn_ipv6_subnet",
        "enable_dhcp": true,
        "network_id": "5fb6e896-8a6d-4657-be93-847549662952",
        "tenant_id": "00000000000000000000000000000001",
        "dns_nameservers": [],
        "gateway_ip": "def0:4141:ab53::1",
        "ip_version": 6
    }
}

[RESPONSE]
[200] OK
body:
{
    "subnet": {
        "allocation_pools": [
            {
                "start": "def0:4141:ab53::2",
                "stop": "def0:4141:ab53:0:ffff:ffff:ffff:ffff"
            }
        ],
        "ipv6_address_mode": "dhcpv6_stateful",
        "cidr": "def0:4141:ab53::/64",
        "id": "02441ffd-4072-4877-8489-c18527c6ec79",
        "name": "moshe_ovn_ipv6_subnet",
        "enable_dhcp": true,
        "network_id": "5fb6e896-8a6d-4657-be93-847549662952",
        "tenant_id": "00000000000000000000000000000001",
        "dns_nameservers": [],
        "gateway_ip": "def0:4141:ab53::1",
        "ip_version": 6
    }
}

Version-Release number of selected component (if applicable):
---------------------------------------------------------------
ovirt-provider-ovn-1.2.22-0.20190424100824.gita51fe76.el7.noarch
ovirt-engine-4.4.0-0.0.master.20190416073615.gitba51258.el7.noarch
How reproducible:


Steps to Reproduce:
------------------
1. Create an IPv6 subnet
2. Update the 'ipv6_address_mode' parameter

Actual results:
----------------
The provider returns an OK response but does not update anything

Expected results:
-----------------
An error should be returned by the provider indicating this parameter cannot be changed once the subnet is created

Comment 1 Dominik Holler 2019-05-09 10:10:40 UTC
Moshe, do you allow us to include the fix into 4.3.4?

Comment 2 Michael Burman 2019-05-13 11:00:25 UTC
(In reply to Dominik Holler from comment #1)
> Moshe, do you allow us to include the fix into 4.3.4?

Yes we are.

Comment 3 msheena 2019-05-27 07:57:42 UTC
Verified on:
------------
RHV 4.3.4.1-0.1.el7
ovirt-provider-ovn-1.2.22-1.el7ev.noarch

Comment 4 Sandro Bonazzola 2019-06-11 06:24:05 UTC
This bugzilla is included in oVirt 4.3.4 release, published on June 11th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.