Bug 1707886 - In assigning an alert profile, Tag Category dropdown doesn't go away after selected
Summary: In assigning an alert profile, Tag Category dropdown doesn't go away after se...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.11.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.11.0
Assignee: Harpreet Kataria
QA Contact: John Dupuy
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-08 15:58 UTC by John Dupuy
Modified: 2019-12-13 15:16 UTC (History)
8 users (show)

Fixed In Version: 5.11.0.4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-13 15:16:27 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot of the BZ (30.16 KB, image/png)
2019-05-08 15:58 UTC, John Dupuy
no flags Details

Description John Dupuy 2019-05-08 15:58:06 UTC
Created attachment 1565720 [details]
screenshot of the BZ

Description of problem:
During alert profile assignment, if you select e.g. "Tagged Providers" for a VM and Instance alert, a new dropdown to select "Tag Category" appears. If you then change "Assign To" to e.g. "Selected Folders", the "Tag Category" dropdown remains. This is a regression, it worked in CFME 5.11.0.2

Version-Release number of selected component (if applicable):
CFME 5.11.0.3

How reproducible:
100%

Steps to Reproduce:
1. Create VM and Instance Alert
2. Create VM and Instance Alert Profile
3. Configuration -> Edit Assignments for this alert profile
4. Assign to -> "Tag Category" (dropdown appears)
5. Assign to -> "Selected Folders"

Actual results:
Dropdown for "Tag Category" still remains

Expected results:
Dropdown for "Tag Category" should disappear

Additional info:
I believe that BZ 1707871 is causing this BZ.

Comment 4 CFME Bot 2019-05-09 09:01:09 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/295ac4c9c1eff7fe14f2721981d52664d2d90d0f
commit 295ac4c9c1eff7fe14f2721981d52664d2d90d0f
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed May  8 16:21:26 2019 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed May  8 16:21:26 2019 -0400

    Removed 'type' argument passed to the tree builder

    Fixed 2 issues
    - Fixed `wrong number of arguments (given 4, expected 3)` error, removed 'type' argument that was being passed in to tree builder code, was introduced by https://github.com/ManageIQ/manageiq-ui-classic/pull/5495
    - Fixed `comparison of Integer with String failed` error for `@assign[:new][:objects].sort!`, changed to push integer into objects array to fix comparison error on the sort when selecting nodes in the tree in 'Selections' box.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707871
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707886

 app/controllers/miq_policy_controller/alert_profiles.rb | 13 +-
 spec/controllers/miq_policy_controller/alert_profiles_spec.rb | 25 +
 2 files changed, 31 insertions(+), 7 deletions(-)

Comment 5 John Dupuy 2019-05-15 18:39:23 UTC
Verified in 


Steps of verification:
1. Create VM and Instance Alert
2. Create VM and Instance Alert Profile
3. Configuration -> Edit Assignments for this alert profile
4. Assign to -> "Tag Category" (dropdown appears)
5. Assign to -> "Selected Folders"
6. Verified that "Tag Category" dropdown doesn't stay displayed.

Comment 6 John Dupuy 2019-05-15 18:39:56 UTC
Verified in 5.11.0.4.20190514210444_0c91ee1, forgot to pasted that above


Note You need to log in before you can comment on or make changes to this bug.