Description of problem: You can edit a dialog and change fields and save them but if you don't save the dialog, you can exit without any warning. All of your changes are not saved. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Edit a dialog 2. Edit and save as many fields as many times as you like 3. Exit without saving the dialog Actual results: All of your changes are not saved Expected results: If any dialog field is changed, the UI should confirm that you want to exit without saving your dialog. Additional info: This might sound like a trivia thing but I don't think it is. Sometimes the dialog Save button isn't even visible unless you scroll down.
https://github.com/ManageIQ/manageiq-ui-classic/pull/5612
https://github.com/ManageIQ/ui-components/pull/387
New commit detected on ManageIQ/ui-components/master: https://github.com/ManageIQ/ui-components/commit/ac540d82ffcecacef46570dda07b62b986ee462a commit ac540d82ffcecacef46570dda07b62b986ee462a Author: Roman Blanco <rblanco> AuthorDate: Mon May 20 05:10:14 2019 -0400 Commit: Roman Blanco <rblanco> CommitDate: Mon May 20 05:10:14 2019 -0400 Use sessionStorage to avoid loss of unsaved dialog Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1707961 src/dialog-editor/components/modal/modalComponent.ts | 6 + src/dialog-editor/components/tab-list/tabListComponent.ts | 3 + src/dialog-editor/services/dialogEditorService.spec.ts | 27 +- src/dialog-editor/services/dialogEditorService.ts | 19 +- 4 files changed, 53 insertions(+), 2 deletions(-)
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/62c50e0af7324eee16bc333b65d801e4398a5674 commit 62c50e0af7324eee16bc333b65d801e4398a5674 Author: Roman Blanco <rblanco> AuthorDate: Mon May 20 05:10:29 2019 -0400 Commit: Roman Blanco <rblanco> CommitDate: Mon May 20 05:10:29 2019 -0400 Use sessionStorage to avoid loss of unsaved dialog Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1707961 app/assets/javascripts/controllers/dialog_editor/dialog_editor_controller.js | 21 + 1 file changed, 21 insertions(+)
Changed version to 5.9.9
Verified in Version 5.11.0.8.20190611155126_01e077e
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:4199