Bug 1708163 - tests: fix bug-1319374.c compile warnings.
Summary: tests: fix bug-1319374.c compile warnings.
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tests
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-09 09:19 UTC by Ravishankar N
Modified: 2019-05-10 14:54 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-10 14:54:50 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 22691 0 None Merged tests: fix bug-1319374.c compile warnings. 2019-05-10 14:54:49 UTC

Description Ravishankar N 2019-05-09 09:19:59 UTC
Description of problem:

    tests: fix bug-1319374.c compile warnings.

    I was looking at a downstream failure of bug-1319374-THIS-crash.t when I
    saw the compiler was throwing a warning while running the test:

    tests/bugs/gfapi/bug-1319374.c:17:61: warning: implicit declaration of function ‘strerror’; did you mean ‘perror’? [-Wimplicit-function-declaration]
             fprintf(stderr, "\nglfs_new: returned NULL (%s)\n", strerror(errno));
                                                                 ^~~~~~~~
                                                                 perror

    So I compiled the .c with -Wall and saw a lot many more warnings, all
    due of a missing header.

Comment 1 Worker Ant 2019-05-09 09:23:09 UTC
REVIEW: https://review.gluster.org/22691 (tests: fix bug-1319374.c compile warnings.) posted (#1) for review on master by Ravishankar N

Comment 2 Worker Ant 2019-05-10 14:54:50 UTC
REVIEW: https://review.gluster.org/22691 (tests: fix bug-1319374.c compile warnings.) merged (#2) on master by Raghavendra Talur


Note You need to log in before you can comment on or make changes to this bug.