Bug 1708875 (python-tmuxp) - Review Request: python-tmuxp - Tmux session manager
Summary: Review Request: python-tmuxp - Tmux session manager
Keywords:
Status: CLOSED ERRATA
Alias: python-tmuxp
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-11 09:57 UTC by Igor Raits
Modified: 2019-06-09 00:28 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-06-09 00:28:26 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Igor Raits 2019-05-11 09:57:30 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-tmuxp.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-tmuxp-1.5.1-1.fc31.src.rpm
Description:
Tmux session manager.
Fedora Account System Username: ignatenkobrain

Comment 1 Neal Gompa 2019-05-11 14:46:26 UTC
Taking this review.

Comment 2 Neal Gompa 2019-05-11 14:47:29 UTC
This package doesn't follow the Fedora Python packaging guidelines at all, since it doesn't produce a python3-tmuxp subpackage where the stuff actually lives. Please fix that.

Also, please add a comment about why you're removing the upper constraint on the click dependency.

Comment 4 Neal Gompa 2019-05-11 15:28:47 UTC
Review notes:

[x] Follows Fedora Packaging Guidelines
[x] Follows packaging guidelines for Python
[x] Package builds and installs correctly
[x] Package follows naming guidelines

PACKAGE APPROVED.

Comment 5 Igor Raits 2019-05-11 16:24:08 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-tmuxp

Comment 6 Fedora Update System 2019-05-11 18:39:04 UTC
python-kaptan-0.5.12-1.fc30 python-libtmux-0.8.1-1.fc30 python-tmuxp-1.5.1-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-72cc996e43

Comment 7 Fedora Update System 2019-05-12 00:45:22 UTC
python-kaptan-0.5.12-1.fc30, python-libtmux-0.8.1-1.fc30, python-tmuxp-1.5.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-72cc996e43

Comment 8 Fedora Update System 2019-06-09 00:28:26 UTC
python-kaptan-0.5.12-1.fc30, python-libtmux-0.8.1-1.fc30, python-tmuxp-1.5.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.