Bug 1709201 - Change md5 checksum used in GlusterHooks calls
Summary: Change md5 checksum used in GlusterHooks calls
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Gluster
Version: 4.30.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.3.6
: 4.30.24
Assignee: Sahina Bose
QA Contact: SATHEESARAN
URL:
Whiteboard:
: 1714783 (view as bug list)
Depends On:
Blocks: 1640357 1723676
TreeView+ depends on / blocked
 
Reported: 2019-05-13 07:45 UTC by Sahina Bose
Modified: 2019-09-26 19:42 UTC (History)
5 users (show)

Fixed In Version: ovirt-engine-4.3.6.3
Doc Type: Bug Fix
Doc Text:
Cause: MD5 checksum is used to compare gluster hook scripts across servers Consequence: Call to get gluster hooks installed on a server fails on FIPs enabled system Fix: Change to use sha256 checksum.
Clone Of:
: 1723676 (view as bug list)
Environment:
Last Closed: 2019-09-26 19:42:50 UTC
oVirt Team: Gluster
Embargoed:
sabose: ovirt-4.3?

Attachments (Terms of Use)
engine.log.snip (95.30 KB, application/octet-stream)
2019-07-18 13:44 UTC, SATHEESARAN 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 99961 0 master MERGED gluster: Change from md5 checksum computation for gluster hooks 2019-07-01 09:45:29 UTC
oVirt gerrit 99975 0 master MERGED gluster: Use new key for checksum in Gluster hooks 2019-07-01 15:01:58 UTC
oVirt gerrit 100822 0 master MERGED gluster: Adding tests for gluster module - hook 2019-07-23 06:39:30 UTC
oVirt gerrit 101390 0 ovirt-4.3 MERGED gluster: Change from md5 checksum computation for gluster hooks 2019-07-08 07:48:50 UTC
oVirt gerrit 101411 0 ovirt-engine-4.3 MERGED gluster: Use new key for checksum in Gluster hooks 2019-07-02 05:52:08 UTC
oVirt gerrit 101895 0 master MERGED engine: Fixed the arg for gluster hooks 2019-08-13 09:23:15 UTC
oVirt gerrit 102600 0 ovirt-engine-4.3 MERGED engine: Fixed the arg for gluster hooks 2019-08-14 09:30:54 UTC

Description Sahina Bose 2019-05-13 07:45:09 UTC 
Description of problem:

In order to run on FIPS compliant system the checksum computation that's used for gluster hooks scripts should be changed to sha256 computation

Version-Release number of selected component (if applicable):


How reproducible:
NA
Comment 2 Sahina Bose 2019-06-18 15:15:27 UTC 
*** Bug 1714783 has been marked as a duplicate of this bug. ***
Comment 6 SATHEESARAN 2019-07-18 13:42:11 UTC 
Tested with RHV 4.3.5.4 and RHGS 3.4.4 async ( glusterfs-3.12.2-47.2 )

Gluster Hooks are not available under the cluster for the first time, then later
when syncing them, all the available and enabled hooks are listed promptly.

But when trying to 'resolve conflicts' - the wizard shows 'MD5sum', but its actually the 'sha256sum'
Its just the UI misdirection.

The other major issue is that, when actually 'resolving conflicts' by copying the hook scripts to
the missing host, null pointer exception is seen

Based on the above reasons, marking this bug as failed verification
Comment 7 SATHEESARAN 2019-07-18 13:44:12 UTC 
Created attachment 1591785 [details]
engine.log.snip
Comment 8 SATHEESARAN 2019-07-18 13:45:04 UTC 
Comment on attachment 1591785 [details]
engine.log.snip

Engine.log related to failed verification of this bug
Comment 9 SATHEESARAN 2019-07-18 17:06:54 UTC 
After discussion with Sahina, this issue doesn't have high severity or urgency.
This is not a blocker, this bug willplanned for RHV 4.3.6
Comment 10 SATHEESARAN 2019-09-04 00:19:14 UTC 
I still do see exception while copying the hooks. I will raise a separate bug for the same.
This bug is specific about implementation of sha256sum for hook scripts instead of md5sum.
That is done and verified with ovirt-engine-4.3.6.3
Comment 11 Sandro Bonazzola 2019-09-26 19:42:50 UTC 
This bugzilla is included in oVirt 4.3.6 release, published on September 26th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.6 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.