Spec URL: https://github.com/jpechane/postgres-decoderbufs/tree/DBZ-1272/rpms SRPM URL: https://copr.fedorainfracloud.org/coprs/jpechane/postgres-decoderbufs/ Description: This is a logical decoding plugin that allows the client to extract replication messages from PostgreSQL server and encode and deliver them as Protocol Buffers messages. The example of client is Debezium (https://debezium.io/) PostgreSQL Kafka source plugin that receives the database change messages and sends them to Kafka message broker. Fedora Account System Username: jpechane
There is one issue that needs a fix: The tag includes "MIT License", but it should only include "MIT". Otherwise looks good to me. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Unversioned .so is ok for postgresql modules, located in private %_libdir. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT/X11 (BSD like)". 7 files have unknown license. Detailed output of licensecheck in /home/hhorak/tmp/review/review-postgres-decoderbufs/licensecheck.txt The tag includes "MIT License", but it should only include "MIT". [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/pgsql Owned by postgresql-server, and the postgresql-server runtime dependency is automatically generated as postgresql-server(:MODULE_COMPAT_11). [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. The BuildRequires only support postgresql v11, but the justification is not mentioned. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in postgres-decoderbufs [?]: Package functions as described. Did not check. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: postgres-decoderbufs-0.9.5-1.fc30.x86_64.rpm postgres-decoderbufs-debuginfo-0.9.5-1.fc30.x86_64.rpm postgres-decoderbufs-debugsource-0.9.5-1.fc30.x86_64.rpm postgres-decoderbufs-0.9.5-1.fc30.src.rpm postgres-decoderbufs.x86_64: E: description-line-too-long C A PostgreSQL logical decoder output plugin to deliver data as Protocol Buffers messages. postgres-decoderbufs.x86_64: W: invalid-license MIT License postgres-decoderbufs-debuginfo.x86_64: W: invalid-license MIT License postgres-decoderbufs-debugsource.x86_64: W: invalid-license MIT License postgres-decoderbufs.src: E: description-line-too-long C A PostgreSQL logical decoder output plugin to deliver data as Protocol Buffers messages. postgres-decoderbufs.src: W: invalid-license MIT License 4 packages and 0 specfiles checked; 2 errors, 4 warnings.
The License is now fixed: https://raw.githubusercontent.com/jpechane/postgres-decoderbufs/DBZ-1272/rpms/postgres-decoderbufs.spec I still strictly recommend to re-consider the BuildDependencies that are tight so strictly to a version v11 and add a comment why it is done so. It's not a blocker from my PoV, so approving.
I've relaxed build dependency version to those we know it works and test with it.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/postgres-decoderbufs