Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1709729

Summary:	[DOCS] Before creating machinehealthcheck resource we should enable machine-healthcheck
Product:	OpenShift Container Platform	Reporter:	sunzhaohua <zhsun>
Component:	Documentation	Assignee:	Kathryn Alexander <kalexand>
Status:	CLOSED CURRENTRELEASE	QA Contact:	sunzhaohua <zhsun>
Severity:	medium	Docs Contact:	Vikram Goyal <vigoyal>
Priority:	medium
Version:	4.1.0	CC:	aos-bugs, jokerman, mmccomas
Target Milestone:	---
Target Release:	4.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-21 17:48:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description sunzhaohua 2019-05-14 08:30:50 UTC

Document URL: 
https://docs.openshift.com/container-platform/4.1/machine_management/deploying-machine-health-checks.html

Section Number and Name: 

Describe the issue:
Machine health check is disabled by default, before creating machinehealthcheck resource we should enable machine-healthcheck by creating a feature gate:

```
apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
  name: machine-api
spec:
  featureSet: TechPreviewNoUpgrade 
```
FYI: https://bugzilla.redhat.com/show_bug.cgi?id=1700885


Suggestions for improvement: 
Before creating machinehealthcheck resource we should enable machine-healthcheck by creating a feature gate.


Additional information:

Comment 1 Kathryn Alexander 2019-05-14 19:09:06 UTC

Here's the PR: https://github.com/openshift/openshift-docs/pull/14853

Zhaohua Sun, will you PTAL?

Comment 2 sunzhaohua 2019-05-16 08:59:41 UTC

In my understanding different features have different FeatureGate name, for machinehealthcheck it is machine-api. We should point this out to know how to enable machinehealthcheck.

Comment 3 Kathryn Alexander 2019-05-16 13:24:43 UTC

Jan opened https://github.com/openshift/machine-api-operator/pull/318 to make the machinehealthcheck use the same feature gate as the other TP features. I'm waiting to see if merges for GA. If merges, the docs on the PR should be validated as-is. If it does not merge in time, I'll use Zhaohua Sun's comments on the PR to make changes for GA and make a follow-up task to confirm that the feature gate doesn't change again.

Comment 4 Kathryn Alexander 2019-05-17 12:21:09 UTC

Jan's PR merged.

Zhaohua Sun, will you PTAL?

Comment 5 sunzhaohua 2019-05-20 03:06:48 UTC

Verified.

Change the cluster spec to  "featureSet: TechPreviewNoUpgrade" could enable the machinehealthcheck and work well.

Comment 6 Kathryn Alexander 2019-05-20 12:38:02 UTC

Fantastic. Thank you!

I've merged the change and am waiting for it to go live.

Comment 7 Kathryn Alexander 2019-05-21 17:48:04 UTC

This change is live.