Spec URL: https://fujiwara.fedorapeople.org/ibus/anthy-unicode/anthy-unicode.spec SRPM URL: https://fujiwara.fedorapeople.org/ibus/anthy-unicode/anthy-unicode-1.0.0.20190412-1.fc30.src.rpm Description: Anthy Unicode is another Anthy project and provides the library to input Japanese on the applications, such as X applications and emacs. and the user dictionaries and the users information which is used for the conversion, is stored into their own home directory. So Anthy Unicode is secure than other conversion server. Fedora Account System Username: fujiwara
Updated the SRPM Spec URL: https://fujiwara.fedorapeople.org/ibus/anthy-unicode/anthy-unicode.spec SRPM URL: https://fujiwara.fedorapeople.org/ibus/anthy-unicode/anthy-unicode-1.0.0.20190412-3.fc30.src.rpm - Delete Group tags - Make parse_modify_freq_command() for UTF-8 - Revert ptab.h to EUC-JP - Fix some obsolete warnings in emacs batch-byte-compile
further more analysis of this package, I see anthy-unicode can split 2 more (noarch) subpackages emacs-anthy-unicode and xemacs-anthy-unicode. See how to package them https://fedoraproject.org/wiki/Packaging:Emacs#Template_for_a_package_for_both_GNU_Emacs_and_XEmacs_.28Case_I.29 Rest looks good. please submit updated srpm.
Updated the SRPM Spec URL: https://fujiwara.fedorapeople.org/ibus/anthy-unicode/anthy-unicode.spec SRPM URL: https://fujiwara.fedorapeople.org/ibus/anthy-unicode/anthy-unicode-1.0.0.20190412-5.fc30.src.rpm
Sorry for being late to review this. Package Review ============== 1)[!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/xemacs/site- packages/lisp/site-start.d, /usr/share/xemacs/site-packages, /usr/share/xemacs, /usr/share/xemacs/site-packages/lisp You are missing below lines in spec at respective sub-packages section Requires: emacs-filesystem >= %{_emacs_version} Requires: xemacs-filesystem >= %{_xemacs_version} 2) Rpmlint ------- Checking: anthy-unicode-1.0.0.20190412-5.fc31.x86_64.rpm emacs-anthy-unicode-1.0.0.20190412-5.fc31.noarch.rpm xemacs-anthy-unicode-1.0.0.20190412-5.fc31.noarch.rpm anthy-unicode-devel-1.0.0.20190412-5.fc31.x86_64.rpm anthy-unicode-debuginfo-1.0.0.20190412-5.fc31.x86_64.rpm anthy-unicode-debugsource-1.0.0.20190412-5.fc31.x86_64.rpm anthy-unicode-1.0.0.20190412-5.fc31.src.rpm anthy-unicode.x86_64: W: spelling-error %description -l en_US emacs -> Emacs, macs, maces anthy-unicode.x86_64: W: shared-lib-calls-exit /usr/lib64/libanthydic-unicode.so.0.1.0 exit.5 anthy-unicode.x86_64: W: non-conffile-in-etc /etc/anthy-unicode.conf anthy-unicode.x86_64: W: no-manual-page-for-binary anthy-agent-unicode anthy-unicode.x86_64: W: no-manual-page-for-binary anthy-dic-tool-unicode anthy-unicode.x86_64: W: no-manual-page-for-binary anthy-morphological-analyzer-unicode emacs-anthy-unicode.noarch: W: spelling-error %description -l en_US elips -> plies, lips, slips emacs-anthy-unicode.noarch: E: description-line-too-long C This package contains the byte compiled elips packages to run anthy-unicode with GNU xemacs-anthy-unicode.noarch: W: spelling-error %description -l en_US elips -> plies, lips, slips anthy-unicode-debugsource.x86_64: W: invalid-url URL: https://github.com/fujiwarat/anthy-unicode/wiki The read operation timed out 7 packages and 0 specfiles checked; 1 errors, 9 warnings. => Fix the description of emacs-anthy-unicode to 80 chars per line Other than this, package looks good. APPROVED. You can import the fixed package.
Updated the SRPM Spec URL: https://fujiwara.fedorapeople.org/ibus/anthy-unicode/anthy-unicode.spec SRPM URL: https://fujiwara.fedorapeople.org/ibus/anthy-unicode/anthy-unicode-1.0.0.20190412-6.fc30.src.rpm
(In reply to Parag AN(पराग) from comment #4) > You are missing below lines in spec at respective sub-packages section > > Requires: emacs-filesystem >= %{_emacs_version} > Requires: xemacs-filesystem >= %{_xemacs_version} These lines are replaced with ?emacs(bin) >= %{_?emacs_version}
https://pagure.io/releng/fedora-scm-requests/issue/13925
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/anthy-unicode