Description of problem: federation-group parameter has no effect for kubefedctl disable cmd Version-Release number of selected component (if applicable): Federation v2 controller-manager version: version.Info{Version:"v0.0.10", GitCommit:"71d233ede685707df554ef653e06bf7f0229415c", GitTreeState:"clean", BuildDate:"2019-05-06T22:54:46Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"} kubefedctl version: version.Info{Version:"v0.0.10-dirty", GitCommit:"71d233ede685707df554ef653e06bf7f0229415c", GitTreeState:"dirty", BuildDate:"2019-05-06T22:30:31Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"} How reproducible: Always Steps to Reproduce: 1. Enable Service federation with "federation.openshift.io" federation group $ ./kubefedctl enable Service --federation-group federation.openshift.io -v 2 I0515 14:27:15.535367 11955 enable.go:202] Found type "services.core/v1" customresourcedefinition.apiextensions.k8s.io/federatedservices.federation.openshift.io created federatedtypeconfig.core.federation.k8s.io/services created in namespace federation-system $ oc get crd federatedservices.federation.openshift.io NAME CREATED AT federatedservices.federation.openshift.io 2019-05-15T06:33:26Z 2. Disable Service federation and delete crd with "federation.k8s.io" federation group. Actual results: $ ./kubefedctl disable services --delete-crd --federation-group federation.k8s.io Disabled propagation for FederatedTypeConfig "federation-system/services" Verifying propagation controller is stopped for FederatedTypeConfig "federation-system/services" Propagation controller for FederatedTypeConfig "federation-system/services" is stopped customresourcedefinition "federatedservices.federation.openshift.io" deleted federatedtypeconfig "federation-system/services" deleted $ oc get crd federatedservices.federation.openshift.io Error from server (NotFound): customresourcedefinitions.apiextensions.k8s.io "federatedservices.federation.openshift.io" not found Expected results: customresourcedefinitions.apiextensions.k8s.io "federatedservices.k8s.openshift.io" not found Or do not support federation-group parameter for disable cmd. Additional info:
--federation-group and --version are not valid for disable. A group-qualified name should be supplied to disable, and federation is only supported for a single version of target type per control plane. I've filed an upstream issue to remove these options from disable: https://github.com/kubernetes-sigs/kubefed/issues/905
The --kubefed-group and --version parameters are now only valid in concert with the --delete-crd flag. This fix should be present in recent releases of kubefed.
Verified with kubefedctl version: version.Info{Version:"v4.2.0", GitCommit:"ee84d241d0d8038640f9dad7cbeb0ea8cce58b6c", GitTreeState:"clean", BuildDate:"2019-08-06T18:27:54Z", GoVersion:"go1.12.6", Compiler:"gc", Platform:"linux/amd64"}
Does this bug require doc text? The Doc Type/Text field is not currently set. Thanks!