Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1710503

Summary:	all-in-one missing network configuration for network-isolation
Product:	Red Hat OpenStack	Reporter:	Victor Voronkov <vvoronko>
Component:	openstack-tripleo-heat-templates	Assignee:	Alex Schultz <aschultz>
Status:	CLOSED ERRATA	QA Contact:	Victor Voronkov <vvoronko>
Severity:	high	Docs Contact:
Priority:	high
Version:	15.0 (Stein)	CC:	aschultz, mburns, mcornea, slinaber
Target Milestone:	beta	Keywords:	Triaged
Target Release:	15.0 (Stein)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-10.5.1-0.20190612140413.fdcfc30.el8ost	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-09-21 11:22:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Victor Voronkov 2019-05-15 16:18:15 UTC

Description of problem:
All-in-one with undercloud fails during the network deployment of the overcloud

Version-Release number of selected component (if applicable):


How reproducible:
Deploy All-in-one with Undercloud 

Steps to Reproduce:
1. Install undercloud
2. make all preparations for Overcloud deployment
3. run overcloud_deploy.sh

Actual results:

Traceback (most recent call last):\\\\n  File \"/bin/os-net-config\", line 10, in <module>\\\\n    sys.exit(main())\\\\n  File \"/usr/lib/python3.6/site-packages/os_net_config/cli.py\", line 270, in main\\\\n    obj = objects.object_from_json(iface_json)\\\\n  File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 51, in object_from_json\\\\n    return OvsBridge.from_json(json)\\\\n  File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 667, in from_json\\\\n    members = _update_members(json, nic_mapping, persist_mapping)\\\\n  File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 121, in _update_members\\\\n    members.append(object_from_json(member))\\\\n  File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 49, in object_from_json\\\\n    return Vlan.from_json(json)\\\\n  File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 521, in from_json\\\\n    opts = _BaseOpts.base_opts_from_json(json)\\\\n  File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 416, in base_opts_from_json\\\\n    addresses.append(Address.from_json(address))\\\\n  File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 275, in from_json\\\\n    ip_netmask = _get_required_field(json, \\\\\\'ip_netmask\\\\\\', \\\\\\'Address\\\\\\')\\\\n  File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 99, in _get_required_field\\\\n    raise InvalidConfigException(msg)\\\\nos_net_config.objects.InvalidConfigException: Address JSON objects
require \\\\\\'ip_netmask\\\\\\' to be configured.\\\\n+ RETVAL=1\\\\n+ set -e\\\\n+ [[ 1 == 2 ]]\\\\n+ [[ 1 != 0 ]]\\\\n+ echo \\\\\\'ERROR: os-net-config configuration failed.\\\\\\'\\\\nERROR: os-net-config c
onfiguration failed.\\\\n+ exit 1

Expected results:
Overcloud deployed successfully

Additional info:

Comment 1 Alex Schultz 2019-05-15 16:25:26 UTC

It turns out that with network-isolation we now need to define the networks on the role themselves or it fails in this fashion. Currently the standalone role[0] does not have any network information associated with it because it can also be shared with a undercloud-less deployment.  We'll need to see if we can get away with adding the network config (like on the controllers[1]) for both scenarios or we'll need to create a new role for this deployment architecture.

[0] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/roles/Standalone.yaml
[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/roles/Controller.yaml#L12-L22

Comment 2 Alex Schultz 2019-05-15 16:42:25 UTC

https://review.opendev.org/#/c/628265/ actually removed them, i guess we'll need to investigate re-adding them or handling this in a different fashion

Comment 3 Alex Schultz 2019-05-15 16:51:23 UTC

Not a blocker as the workaround can be to not use network isolation or add the network information to the role being used.

Comment 7 Victor Voronkov 2019-06-25 20:53:43 UTC

Verified on compose RHOS_TRUNK-15.0-RHEL-8-20190619.n.1

Comment 11 errata-xmlrpc 2019-09-21 11:22:03 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:2811