Bug 1710897 - [v2v][UI] VMware providers are saved under too long names
Summary: [v2v][UI] VMware providers are saved under too long names
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.6.0
Assignee: Marek Libra
QA Contact: Maayan Hadasi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-16 14:15 UTC by Ilanit Stein
Modified: 2020-06-24 18:49 UTC (History)
10 users (show)

Fixed In Version: 4.2.0-0.ci-2019-08-02-184554/
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-30 16:27:11 UTC
Target Upstream Version:
Embargoed:
mlibra: needinfo-


Attachments (Terms of Use)
vmware_name_screenshot (143.86 KB, image/png)
2019-05-16 14:15 UTC, Ilanit Stein
no flags Details
Screenshot (fixed) (63.16 KB, image/png)
2019-12-11 11:40 UTC, Maayan Hadasi
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2020:0307 0 None None None 2020-01-30 16:27:21 UTC

Description Ilanit Stein 2019-05-16 14:15:46 UTC
Created attachment 1569529 [details]
vmware_name_screenshot

Description of problem:
VMware providers, are saved under names, that are too long.
When they are picked from the list of the remembered providers, 
their name cannot be fully viewed (see attached screenshot) 


Version-Release number of selected component (if applicable):
hco_tag: v.2.0.0-12

How reproducible:
100%

Expected results:
Save VMware providers under a shorter name, that can be fully seen in the UI.

Comment 1 Filip Krepinsky 2019-05-21 10:20:22 UTC
This identifies the vcenter.

We could either
- show a tooltip with the full name
- add option to name the vcenters with a custom name when saving the secret

Comment 2 Marek Libra 2019-07-30 08:16:34 UTC
The best option here is in new field with predefined value but allowing the user to provide whatever name (s)he likes.

That can be seen as a new feature and we are in bug-fixing phase now.

So to fix, I propose no aditional changes to the UI but generate the name differently:

The name is no longer than 35 letters.
Composed as: [USERNAME]-[URL]-[UNIQUE]

where
USERNAME - prefix of VMware username - up to 15 letters before '@' (shortened if needed)
URL - prefix of VMware URL, up to "30 - USERNAME.length" characters
UNIQUE - 5 auto generated characters

Comment 3 Tomas Jelinek 2019-07-30 10:05:58 UTC
+1, sounds good

Comment 4 Marek Libra 2019-07-30 12:52:40 UTC
Patch: https://github.com/kubevirt/web-ui-components/pull/530

Comment 5 Tomas Jelinek 2019-09-30 15:05:49 UTC
Since the v2v has been removed from 2.1.0, retargeting bugs to 2.1.1 to make sure they will be verified on the right version.

Comment 6 Brett Thurber 2019-10-21 19:11:19 UTC
Moving to ON_QA.

Comment 7 Nelly Credi 2019-11-11 12:27:15 UTC
please add fixed in version

Comment 8 Marek Libra 2019-11-12 09:23:30 UTC
The change was merged on Jul 30

Comment 9 Maayan Hadasi 2019-12-11 11:40:10 UTC
Created attachment 1643860 [details]
Screenshot (fixed)

Verified as fixed in version: CNV 2.2.0-10

vCenter instance is identified as described in comment #2:

The name is no longer than 35 letters.
Composed as: [USERNAME]-[URL]-[UNIQUE]

where
USERNAME - prefix of VMware username - up to 15 letters before '@' (shortened if needed)
URL - prefix of VMware URL, up to "30 - USERNAME.length" characters
UNIQUE - 5 auto generated characters

Comment 11 errata-xmlrpc 2020-01-30 16:27:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:0307


Note You need to log in before you can comment on or make changes to this bug.