Bug 1711806

YunmingYang I am not sure why you expect the default storage pool to be created automatically. If you are going to use an image from a pool different than the default to boot your VM from why the default pool should be even created?

@Katerina, If the image for the VM creation is in the directory which is '/var/lib/libvirt/images/', a storage pool whose name 'images' will be created. Then, if user use the installation source type which is 'Local Install Media' to create a new VM, the creation will be failed because the directory is used by another storage pool. And there will be also an error which is '
ERROR Error: --disk size=10,format=qcow2: Storage pool not found: no storage pool with matching name 'default' '.

Ok I understand your point. However, cockpit-machines is not doing anything apart from calling virt-install with the appropriate arguments.
So, if something is to be fixed here, is that virt-install should not complain if the directory /var/lib/libvirt/images is used by another pool and continue the operation by creating the new disk in the default directory which is /var/lib/libvirt/images although the user assigned it to pool name !== default.

This was fixed recently in upstream:

commit a0ca387aad0fde19683aa8b5b5636add6455b8b4
Author: Cole Robinson <crobinso>
Date:   Tue Mar 26 10:44:58 2019 -0400

    cli: Fix pool=default when path belongs to another pool (bz 1692489)

Steps to reproduce using virt-install & virsh command directly:

1. Remove default storage pool if it exists.

2. Define new storage pool that will point to the same directory as
   the default one with a different name then 'default:

$ cat pool-images.xml
<pool type='dir'>
  <name>images</name>
  <target>
    <path>/var/lib/libvirt/images</path>
  </target>
</pool>

$ virsh pool-define pool-images.xml

3. Run virt-install command that will try to create new disk in default
   storage pool:

$ virt-install --name def-disk --memory 512 --import --disk size=1

Thanks Pavel, it's supper great for QE to know how to reproduce it.

I can reproduce this bug with build:
virt-manager-1.5.0-6.el7.noarch

Steps:
1. Remove default storage pool if it exists.

2. Define new storage pool that will point to the same directory as the default one with a different name then 'default:

# cat pool-images.xml 
<pool type='dir'>
  <name>images</name>
  <target>
    <path>/var/lib/libvirt/images</path>
  </target>
</pool>


# virsh pool-define pool-images.xml
Pool images defined from pool-images.xml

# virsh pool-start images
Pool images started


3. Run virt-install command that will try to create new disk in default storage pool:

# virt-install --name def-disk --memory 512 --import --disk size=1
ERROR    Error: --disk size=1: Storage pool not found: no storage pool with matching name 'default'

Then try to verify this bug with new build:
virt-manager-1.5.0-7.el7.noarch
virt-install-1.5.0-7.el7.noarch
virt-manager-common-1.5.0-7.el7.noarch
package libvir is not installed
qemu-kvm-rhev-2.12.0-30.el7.x86_64

Steps:
4. Rerun virt-install command that will try to create new disk in default storage pool:

# virt-install --name def-disk --memory 512 --import --disk size=1
WARNING  No operating system detected, VM performance may suffer. Specify an OS with --os-variant for optimal results.

Starting install...
Allocating 'def-disk.qcow2'     
...

Result: No error reports, so I move this bug from ON_QA to VERIFIED.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2232