Spec URL: https://churchyard.fedorapeople.org/SRPMS/python2-more-itertools.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python2-more-itertools-4.1.0-6.fc31.src.rpm Description: Opensource python library wrapping around itertools. Package also includes implementations of the recipes from the itertools documentation. See https://pythonhosted.org/more-itertools/index.html for documentation. Fedora Account System Username: churchyard
> rpmlint -i ./python2-more-itertools-4.1.0-6.fc31.src.rpm python2-more-itertools.src: W: spelling-error %description -l en_US Opensource -> Open source, Open-source, Outsource The value of this tag appears to be misspelled. Please double-check. 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
I will change the description to: Python's itertools library is a gem - you can compose elegant solutions for a variety of problems with the functions it provides. In more-itertools we collect additional building blocks, recipes, and routines for working with Python iterables. Python 2 version.
Package APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python2-devel is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ This is expected. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [-]: Latest version is packaged. * The latest upstream is py3-only. This uses the same version as when it was forked from python-more-itertools. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-more-itertools-4.1.0-6.fc31.noarch.rpm python2-more-itertools-4.1.0-6.fc31.src.rpm python2-more-itertools.noarch: W: spelling-error %description -l en_US Opensource -> Open source, Open-source, Outsource python2-more-itertools.src: W: spelling-error %description -l en_US Opensource -> Open source, Open-source, Outsource 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python2-more-itertools.noarch: W: spelling-error %description -l en_US Opensource -> Open source, Open-source, Outsource 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/m/more-itertools/more-itertools-4.1.0.tar.gz : CHECKSUM(SHA256) this package : c9ce7eccdcb901a2c75d326ea134e0886abfbea5f93e91cc95de9507c0816c44 CHECKSUM(SHA256) upstream package : c9ce7eccdcb901a2c75d326ea134e0886abfbea5f93e91cc95de9507c0816c44 Requires -------- python2-more-itertools (rpmlib, GLIBC filtered): python(abi) python2.7dist(six) Provides -------- python2-more-itertools: python-more-itertools python2-more-itertools python2.7dist(more-itertools) python2dist(more-itertools)
Thank You! https://pagure.io/releng/fedora-scm-requests/issue/11732
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python2-more-itertools
Thanks everybody.
Shouldn't we update it to 5.0.0? Looking at https://github.com/erikrose/more-itertools/releases, that'd be the last release with Python2 support.
Already done in rawhide.