Description of problem: attempting to copy and save a service dialog with the same name results in dialog fields tabs being duplicated Screen shot attached. Tabs are duplicated showing multiple tabs of VM DETAILS, and Additional disks. Version-Release number of selected component (if applicable): 5.10.3 How reproducible: Every time Steps to Reproduce: 1. Copy service dialog "Test DIalog" save as "Copy of Test Dialog" 2. Copy service dialog "Test DIalog" attempt to save as "Copy of Test Dialog" You will receive an error stating dialog name already exists. The original "Test Dialog" will have all of its tabs duplicated. Actual results: Tabs are copied and showing multiple times. Expected results: Additional info:
Created attachment 1572161 [details] Duplicate tabs
*** Bug 1713101 has been marked as a duplicate of this bug. ***
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/4962568f5586895f95fc7d0b7093737e4d3de041 commit 4962568f5586895f95fc7d0b7093737e4d3de041 Author: Martin Hradil <mhradil> AuthorDate: Tue Jul 23 10:26:57 2019 -0400 Commit: Martin Hradil <mhradil> CommitDate: Tue Jul 23 10:26:57 2019 -0400 Dialog copy - remove ids pointing to the original dialog When copying a dialog, we load the original, allow the user to change it, and save that data as a new dialog. But, the API just saves the fields, groups and tabs, then saves the dialog, and only after that updates those tabs to point to the new dialog. No transactions. Which means that when dialog validation fails, all the copied tabs still point to the original dialog, leading to duplicate tabs appearing in the original. This does not fix the API bug or attempt to wrap it in a transaction, this just makes sure the UI won't send any obsolete ids when copying, thus limiting the impact of the API bug to extra unused tabs remaining in the db. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1713100 app/assets/javascripts/controllers/dialog_editor/dialog_editor_controller.js | 16 + 1 file changed, 16 insertions(+)
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/9e9d63e2ec014989eca31bfaa57f61623c6c790a commit 9e9d63e2ec014989eca31bfaa57f61623c6c790a Author: Milan Zázrivec <mzazrivec> AuthorDate: Thu Jul 25 06:04:05 2019 -0400 Commit: Milan Zázrivec <mzazrivec> CommitDate: Thu Jul 25 06:04:05 2019 -0400 Merge pull request #5856 from himdel/dialog-copy Dialog copy - remove ids pointing to the original dialog (cherry picked from commit 9c807596ac916a4356662aef891c57589791780e) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1713100 app/assets/javascripts/controllers/dialog_editor/dialog_editor_controller.js | 16 + 1 file changed, 16 insertions(+)
Verified in Version 5.11.0.17.20190730152352_93b1c30