Bug 1713604 - Review Request: onvifviewer - Network camera viewer
Summary: Review Request: onvifviewer - Network camera viewer
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-Legal
TreeView+ depends on / blocked
 
Reported: 2019-05-24 08:49 UTC by Casper Meijn
Modified: 2019-06-06 16:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Casper Meijn 2019-05-24 08:49:03 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/ONVIFViewer/fedora-rawhide-x86_64/00915058-onvifviewer/onvifviewer.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/ONVIFViewer/fedora-rawhide-x86_64/00915058-onvifviewer/onvifviewer-0.10-1.fc31.src.rpm
Description: The goal of this project is to replace the proprietary app that was needed to 
configure and view my IP camera. The ONVIF protocol can be used to view and 
configure many types of camera's and is a open standard that can be implemented 
using standard SOAP libraries. Using Qt5 for the back-end and Kirigami UI 
framework makes this application a cross-platform solution.
Fedora Account System Username: caspermeijn


There are two things that I am not sure of:
* The source files related to the ONVIF protocol may be distributed, but not modified. Is this allowed in the source package? Does this need to be stated in the spec file? Does this change the license of the binary (and with that the License field)?
* The tests in the package require a X server. Is this possible during a rpmbuild? Is it useful to run these tests?
Thanks in advance.

Comment 1 Robert-André Mauchin 2019-06-06 14:38:59 UTC
 - Not needed:

rm -rf %{buildroot}

>The tests in the package require a X server. Is this possible during a rpmbuild? Is it useful to run these tests?

You could try running them with xvfb-run, not sure it will work.

> The source files related to the ONVIF protocol may be distributed, but not modified. Is this allowed in the source package? Does this need to be stated in the spec file? Does this change the license of the binary (and with that the License field)?

I'm not sure, asking FE-Legal opinion on this

Comment 2 Tom "spot" Callaway 2019-06-06 16:08:20 UTC
Ugh, this is complicated. I'm going to have to discuss this internally. Please hold on doing anything with this package for the time being.


Note You need to log in before you can comment on or make changes to this bug.