Description of problem: Fedora review chokes on reviews that use IDN. For example: https://bugzilla.redhat.com/show_bug.cgi?id=1692166 It seems to try to convert the URL from https://www.rombobjörn.se/... to https://www.rombobjorn.se/... and consequently fails at: ERROR: 'Error [Errno socket error] [Errno -2] Name or service not known downloading https://www.rombobjrn.se/packages/gnatcoll-db-2018-2/gnatcoll-db-2018-2.fc30.src.rpm' (logs in /home/rjones/.cache/fedora-review.log) Version-Release number of selected component (if applicable): fedora-review-0.7.2-1.fc30.noarch How reproducible: 100% Steps to Reproduce: 1. fedora-review -b 1692166
Created attachment 1573116 [details] fedora-review.log
Oh that's not quite right. In fact it's simply ignoring the non-ASCII character.
I made a set of pages that allow testing how fedora-review handles internationalized domain names and Internationalized Resource Identifiers in various combinations. Both the address to the page and the links on the page can be either IRIs, URLs encoded in ACE and percent encoding, or restricted to ASCII. (My ASCII-only workaround domain has no certificate, so the ASCII URLs use insecure HTTP.) Here's a selection of results from Rawhide: IRI on the command line, IRI links: fedora-review --url https://www.Rombobjörn.se/packages/IRItest/här/IRI → fails without contacting the server: “UnicodeEncodeError: 'ascii' codec can't encode character '\xe4' in position 23: ordinal not in range(128)” ACE URL on the command line, IRI links: fedora-review --url https://www.xn--rombobjrn-67a.se/packages/IRItest/h%C3%A4r/IRI → deletes the non-English letters and fails to resolve the resulting nonexistent domain name ACE URL on the command line, ACE links: fedora-review --url https://www.xn--rombobjrn-67a.se/packages/IRItest/h%C3%A4r/ACE → downloads the files correctly ASCII URL on the command line, ASCII links: fedora-review --url http://www.Rombobeorn.se/packages/IRItest/ASCII → downloads the files correctly
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'.
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31.
This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
fedora-review-0.7.5-3.fc33 is no better. The only change is a different error message with an IRI on the command line: ERROR: Cannot find usable urls here ERROR: 'Cannot find .spec or .srpm URL(s)'
This package has changed maintainer in the Fedora. Reassigning to the new maintainer of this component.
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle. Changing version to 34.
This message is a reminder that Fedora Linux 34 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '34'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 34 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle. Changing version to 37.
This message is a reminder that Fedora Linux 37 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 37 on 2023-12-05. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '37'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 37 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
Fedora Linux 37 entered end-of-life (EOL) status on None. Fedora Linux 37 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora Linux please feel free to reopen this bug against that version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see the version field. If you are unable to reopen this bug, please file a new report against an active release. Thank you for reporting this bug and we are sorry it could not be fixed.
Well, there has been some anti-progress. The all-ACE case is also broken now.
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle. Changing version to 40.