Bug 1713897 - /etc/profile.d/lang.csh sets LANG to 1
Summary: /etc/profile.d/lang.csh sets LANG to 1
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: setup
Version: 30
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Martin Osvald 🛹
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-25 14:41 UTC by Albert Flügel
Modified: 2019-10-26 17:24 UTC (History)
3 users (show)

Fixed In Version: setup-2.13.6-1.fc30 setup-2.13.6-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-25 16:59:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Albert Flügel 2019-05-25 14:41:54 UTC
Description of problem:
$Summary
Why ?:
...
    set LANG_backup=${?LANG}
...
    set LANG="${LANG_backup}"

What nonsense. The question mark in the 1st shown line is wrong.

Furthermore in line 51:
    if (${LC_ALL} != ${?LANG} && ${?LANG}) then
same nonesense. Remove the first question mark ASAP.

Whoever has done this change, it has obviously never been tested.
It has passed QA.
Today everybody is fragilely DeathOpsing having infinite trust in automatic testing or what ?

Comment 1 Martin Osvald 🛹 2019-08-29 10:01:25 UTC
Thank you very much for reporting this problem!

Indeed the outcomes of the below patch are unfortunate:

https://pagure.io/setup/c/fef4c093aec7adef9a2ced5b374a3c3354901e10

I will be releasing a fixed setup version soon.

Comment 2 Martin Osvald 🛹 2019-08-29 11:13:38 UTC
the fix is in git, moving to MODIFIED:

https://pagure.io/setup/c/2708586e21b00e5a4898e2a2c798d0ae0b262fce?branch=master

Comment 3 Martin Osvald 🛹 2019-08-30 11:56:08 UTC
(In reply to Albert Flügel from comment #0)
...
> Furthermore in line 51:
>     if (${LC_ALL} != ${?LANG} && ${?LANG}) then
> same nonesense. Remove the first question mark ASAP.

regarding the second issue, the below commit fixes it:

https://pagure.io/setup/c/d5c1a44eabd7f0ded91003c196e85a288eca967e?branch=master

Again, thank you for reporting both problems!

Comment 4 Fedora Update System 2019-10-09 09:57:18 UTC
FEDORA-2019-d30f1a7dd4 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d30f1a7dd4

Comment 5 Fedora Update System 2019-10-09 09:57:25 UTC
FEDORA-2019-c423bdade3 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c423bdade3

Comment 6 Fedora Update System 2019-10-09 17:40:10 UTC
setup-2.13.6-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c423bdade3

Comment 7 Fedora Update System 2019-10-09 23:05:36 UTC
setup-2.13.6-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d30f1a7dd4

Comment 8 Fedora Update System 2019-10-25 16:59:56 UTC
setup-2.13.6-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2019-10-26 17:24:04 UTC
setup-2.13.6-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.