Bug 1714154 - [downstream clone - 4.3.4] When a storage domain is updated to V5 during a DC upgrade, if there are volumes with metadata that has been reset then the upgrade fails
Summary: [downstream clone - 4.3.4] When a storage domain is updated to V5 during a DC...
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: vdsm
Version: 4.3.1
Hardware: Unspecified
OS: Unspecified
Target Milestone: ovirt-4.3.4
: 4.3.1
Assignee: Nir Soffer
QA Contact: Shir Fishbain
Depends On: 1713724
TreeView+ depends on / blocked
Reported: 2019-05-27 09:17 UTC by RHV bug bot
Modified: 2020-08-03 15:28 UTC (History)
9 users (show)

Fixed In Version: vdsm-4.30.17
Doc Type: Bug Fix
Doc Text:
Converting a storage domain to the V5 format failed when there were partly deleted volumes with cleared metadata remaining in the storage domain following an unsuccessful delete volume operation. In this release, storage domain conversion succeeds even when partly deleted volumes with cleared metadata remain in the storage domain.
Clone Of: 1713724
Last Closed: 2019-06-20 14:48:41 UTC
oVirt Team: Storage
Target Upstream Version:
lsvaty: testing_plan_complete-

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 4172251 0 None None Updating the Data Center compatibility level to 4.3 can result in a non-responsive DC and no SPM 2019-05-27 09:18:23 UTC
Red Hat Product Errata RHBA-2019:1567 0 None None None 2019-06-20 14:48:49 UTC
oVirt gerrit 100296 0 'None' MERGED upgrade: Skip volumes with cleared metadata 2020-09-14 15:11:35 UTC
oVirt gerrit 100297 0 'None' MERGED tests: Test converting volume with cleared metadata 2020-09-14 15:11:35 UTC
oVirt gerrit 100334 0 'None' MERGED storage.exception: Fix cleared metadata regressions 2020-09-14 15:11:35 UTC
oVirt gerrit 100335 0 'None' MERGED upgrade: Handle volumes with invalid metadata 2020-09-14 15:11:35 UTC

Description RHV bug bot 2019-05-27 09:17:46 UTC
+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1713724 +++

Description of problem:

If a strorage domain has volume metadata that has been reset (contains "NONE=######...."), then the attempt to upgrade the DC will fail. This appears to leave the DC in a non-responsive state, with no SPM, and no new VMs can be started, etc.

VDSM reports "MetaDataKeyNotFoundError" for each volume metadata area that is in this state.

The volume metadata can perhaps be in this state as a result of a failed live merge at some time in the past, where the volume should have been removed, the metadata was reset, but the removal failed.

Version-Release number of selected component (if applicable):

RHV 4.3.3

How reproducible:

I assume 100%, but I am going to try to reproduce this myself.

Steps to Reproduce:

Actual results:

Expected results:

Additional info:

(Originally by Gordon Watson)

Comment 8 RHV bug bot 2019-05-27 09:18:01 UTC
Gordon, can you attach:
- lvm commands output from sosreport?
- copy of the first MiB of the metadata LV from a domain with this issue.

The attached patch should fix this issue, but it is not tested yet. I can test
in on Sunday, but we can save time if you can test it during the weekend.

(Originally by Nir Soffer)

Comment 9 RHV bug bot 2019-05-27 09:18:03 UTC
## Testing the fix

1. Create a DC/cluster with compatibility version 4.2
2. Create new iSCSI/FC V4 storage domain
3. Add some floating disks
4. Clear the metadata of one or more disks (see "How to clear volume metadata bellow")
5. Upgrade the cluster and DC to version 4.3

Expected result:
- Storage domain upgraded to V5 successfully
- Warning about volume with cleared metadata logged for the volume with this issue

Should be tested with with 4.3.3, reproducing this issue, and then with
a build including this fix, verifying that upgrading storage domain to V5 succeeds.

## How to clear volume metadata

This is not possible since 4.2.5, and impossible to reproduce to older version,
so we have to clear the metadata manually:

1. Find the volume metadata slot using:

  lvs -o vg_name,lv_name,tags -> MD_42

2. Write cleared metadata to the volume metadata area

    import os

    with open("/dev/vg-name/metadata, "rb+") as f:
        f.seek(42 * 512)
        f.write(b"NONE=" + (b"#" * 502) + b"\nEOF\n")

(Originally by Nir Soffer)

Comment 10 RHV bug bot 2019-05-27 09:18:04 UTC
Trying to target to 4.3.4, since this issue breaks upgrades to 4.3, and does not
have an easy workaround.

(Originally by Nir Soffer)

Comment 17 RHV bug bot 2019-05-27 09:18:16 UTC
Also test installing the temp fix vdsm-4.30.16-2.gitfb7cdef.el7.x86_64 before upgrading the CD to 4.3 and at looks well.
SD/DC upgraded to V5/4.3 without issues and all hosts are up.

(Originally by Avihai Efrat)

Comment 19 Shir Fishbain 2019-06-02 14:01:57 UTC

The storage domain upgrades to V5 successfully.


Comment 24 errata-xmlrpc 2019-06-20 14:48:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Comment 25 Daniel Gur 2019-08-28 13:13:52 UTC

Comment 26 Daniel Gur 2019-08-28 13:18:05 UTC

Note You need to log in before you can comment on or make changes to this bug.